This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: simplify x = x <op> y to x <op>= y#2028
Closed
quasilyte wants to merge 1 commit intogolang:masterfrom
quasilyte:quasilyte/assignOp
Closed
gps: simplify x = x <op> y to x <op>= y#2028quasilyte wants to merge 1 commit intogolang:masterfrom quasilyte:quasilyte/assignOp
x = x <op> y to x <op>= y#2028quasilyte wants to merge 1 commit intogolang:masterfrom
quasilyte:quasilyte/assignOp
Conversation
Simplify `x += 1` further to `x++`. Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
kevinburke
reviewed
Feb 17, 2019
| func (m *metrics) push(name string) { | ||
| cn := m.stack[len(m.stack)-1] | ||
| m.times[cn] = m.times[cn] + time.Since(m.last) | ||
| m.times[cn] += +time.Since(m.last) |
Collaborator
There was a problem hiding this comment.
What's the purpose of the + before the time here?
Contributor
Author
There was a problem hiding this comment.
Oh, sorry. It should be omitted. Thanks for spotting.
Collaborator
|
This has been merged! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
x += 1further tox++.Signed-off-by: Iskander Sharipov quasilyte@gmail.com