Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

cmd/dep: replace len(x)<=0 with len(x)==0 #2031

Merged
merged 1 commit into from
Oct 3, 2018
Merged

cmd/dep: replace len(x)<=0 with len(x)==0 #2031

merged 1 commit into from
Oct 3, 2018

Conversation

quasilyte
Copy link
Contributor

Length never returns negative values.

Signed-off-by: Iskander Sharipov quasilyte@gmail.com

Length never returns negative values.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carolynvs carolynvs merged commit 22125cf into golang:master Oct 3, 2018
@quasilyte quasilyte deleted the quasilyte/sloppyLen branch October 4, 2018 02:44
zhyon404 added a commit to zhyon404/dep that referenced this pull request Oct 12, 2018
Length never returns negative values.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
zhyon404 added a commit to zhyon404/dep that referenced this pull request Oct 12, 2018
cmd/dep: replace `len(x)<=0` with `len(x)==0` (golang#2031)
kevinburke pushed a commit to kevinburke/dep that referenced this pull request Dec 19, 2018
Length never returns negative values.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
lhauspie pushed a commit to lhauspie/dep that referenced this pull request Apr 9, 2019
Length never returns negative values.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants