Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gps: ignore "mod" VCS type in parseMetaGoImports #2152

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
5 participants
@dmitshur
Copy link
Member

commented May 7, 2019

Apply the same change as in golang.org/cl/175219 to this copy of the
parseMetaGoImports function, helping keep them in sync.

The "mod" type is not a real version control system (VCS), it applies
only when in module mode. Skip it and continue to consider only real
VCS types.

This resolves parseMetaGoImports returning a "multiple meta tags match
import path" error on packages that offer go-import meta tags with both
a true VCS and the "mod" type.

Reference: https://golang.org/cmd/go/#hdr-Remote_import_paths

Fixes #2151

gps: ignore "mod" VCS type in parseMetaGoImports
Apply the same change as in golang.org/cl/175219 to this copy of the
parseMetaGoImports function, helping keep them in sync.

The "mod" type is not a real version control system (VCS), it applies
only when in module mode. Skip it and continue to consider only real
VCS types.

This resolves parseMetaGoImports returning a "multiple meta tags match
import path" error on packages that offer go-import meta tags with both
a true VCS and the "mod" type.

Reference: https://golang.org/cmd/go/#hdr-Remote_import_paths

Fixes #2151
@JeremyChase

This comment has been minimized.

Copy link

commented May 7, 2019

FWIW I did test this branch and it is resolving my problem similar to #2151

@dmitshur dmitshur requested a review from bcmills May 7, 2019

@bcmills

bcmills approved these changes May 7, 2019

@dmitshur dmitshur merged commit 21c40aa into master May 7, 2019

7 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
cla/google All necessary CLAs are signed
codeclimate All good!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dmitshur dmitshur deleted the sync-parseMetaGoImports branch May 7, 2019

@sdboyer

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@dmitshur - thanks for this.

@bcmills - This was a relatively minor change, so it’s not that big a deal. But, dep does have active maintainers (@kevinburke, @theckman). It's their call on approving and merging PRs - if a situation like this should arise in the future, please consult with them first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.