Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Conversation

@kevinburke
Copy link
Collaborator

This enables support for private gitlab files and other places where
the URL requires basic authentication.

The idea and the large majority of the implementation comes from @wesgur.

Fixes #2061.
Fixes #1898.

@kevinburke kevinburke requested a review from sdboyer as a code owner May 8, 2019 18:15
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2019
This enables support for private gitlab files and other places where
the URL requires basic authentication.

Initial proposal and implementation came from Johnny
(github.com/wesgur).

Fixes golang#2061.
Fixes golang#1898.
@kevinburke kevinburke merged commit a6f1aa1 into golang:master May 8, 2019
@kevinburke kevinburke deleted the wesgur-master branch May 8, 2019 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"dep ensure -add" can't add package in private gitlab. How to use dep with private repos?

2 participants