Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI for go 1.13 #2202

Open
wants to merge 2 commits into
base: master
from
Open

update CI for go 1.13 #2202

wants to merge 2 commits into from

Conversation

@jmank88
Copy link
Collaborator

jmank88 commented Sep 6, 2019

What does this do / why do we need it?

Bumps the go versions for CI, since 1.13 was released.

@jmank88 jmank88 requested a review from sdboyer as a code owner Sep 6, 2019
@googlebot googlebot added the cla: yes label Sep 6, 2019
@@ -35,7 +35,7 @@ jobs:
script:
- make test
- <<: *simple-test
go: 1.9.x
go: 1.11.x

This comment has been minimized.

Copy link
@jmank88

jmank88 Sep 6, 2019

Author Collaborator

+2 here, since I think it was missed last time. Was 9, 11, 12, tip - now is 11, 12, 13, tip.

@sdboyer
sdboyer approved these changes Sep 6, 2019
Copy link
Member

sdboyer left a comment

👍🏻

@jmank88

This comment has been minimized.

Copy link
Collaborator Author

jmank88 commented Sep 6, 2019

Lots of failures on go 1.12 only:

testproj.go:119: go standard error:
            testproj.go:120: failed to initialize build cache at /test-dep-home-does-not-exist/.cache/go-build: mkdir /test-dep-home-does-not-exist: permission denied
                
            testproj.go:123: go [get github.com/sdboyer/deptest] failed unexpectedly: exit status 1
@jmank88 jmank88 force-pushed the go1.13 branch 2 times, most recently from 50452d6 to a46d7b9 Sep 6, 2019
@jmank88 jmank88 force-pushed the go1.13 branch from a46d7b9 to 132bfb3 Sep 6, 2019
@jmank88

This comment has been minimized.

Copy link
Collaborator Author

jmank88 commented Sep 6, 2019

Fixed 👍

@avelino
avelino approved these changes Nov 7, 2019
Copy link

avelino left a comment

LGTM

Copy link

chenrui333 left a comment

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.