New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gps to dep #453

Merged
merged 994 commits into from May 3, 2017

Conversation

Projects
None yet
@kris-nova
Copy link
Contributor

kris-nova commented Apr 21, 2017

Moving a copy of gps at sdboyer/gps@da7569e to github.com/golang/dep/gps

Git history preservation

All git history from gps at sdboyer/gps@da7569e should be preserved.

With the exception of the following sed replacement in the git commit logs:

sed -e "s/ #/ sdboyer\/gps#/"
# git filter-branch -f --msg-filter 'sed -e "s/ #/ sdboyer\/gps#/"' 51d49055235c7e635439ac69c4650556714de37f..HEAD

Global Substitution

  • kris-nova@122ade3
  • sed/g the following strings (somewhat blindly)
    • github.com/sdboyer/gps -> github.com/golang/go/gps
    • github.com/sdboyer/gps/internal -> github.com/golang/dep/gps/internal
    • github.com/sdboyer/gps/pkgtree -> github.com/golang/dep/gps/pkgtree
  • dep is now compiling with the gps no longer in vendor

Remove vendor/github.com/sdboyer/gps

Changes from code review here

ReSTARTR and others added some commits Jan 29, 2017

Merge pull request sdboyer/gps#163 from sdboyer/lp-perms
Ignore dirs/files with perms issues in ListPackages
Introduce monitoredCmd
Introduce monitoredCmd to wrap commands and be able to kill them if
no activity is detected in a certain amount of time.
Changes per review
1. Remove pipe
2. Indent inner messages over 2 spaces
3. s/3spaces/tab in getprei
Merge pull request sdboyer/gps#168 from kris-nova/viz-improvements
Removing nested trace output from trace.go
Add ListPackages case w/slashes in root path
Not covering this basic aspect of how real project roots actually work
allowed a windows bug to hide until real data came through - sdboyer/gps#146.
Remove basedir silliness from wmToReach()
This was never used, because it wasn't actually needed.

sdboyer and others added some commits Apr 29, 2017

Adding headers and bypass env var
DEPTESTBYPASS501 is now respected to bypass the tests that are failing
Adding bypass to fix tests for merge see #501
Updating .travis.yml to set new bypass flag
@sdboyer
Copy link
Member

sdboyer left a comment

ohboyohboyohboyohboy

@@ -16,7 +20,8 @@ func TestSlowVcs(t *testing.T) {
t.Run("source-gateway", testSourceGateway)
t.Run("bzr-repo", testBzrRepo)
t.Run("bzr-source", testBzrSourceInteractions)
t.Run("svn-repo", testSvnRepo)
// TODO(kris-nova) re-enable syn-repo after gps is merged into dep

This comment has been minimized.

@sdboyer

sdboyer May 3, 2017

Member

Why disable this one?

I'm not gonna hold up the PR for it, but noting it so we can make an issue 😄

This comment has been minimized.

@kris-nova

kris-nova May 3, 2017

Contributor

Oh it was failing - let me open an issue with more info and I can get it cleaned up!

This comment has been minimized.

@kris-nova

kris-nova May 3, 2017

Contributor

Issue: #504

@sdboyer sdboyer merged commit f291eab into golang:master May 3, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details
@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented May 3, 2017

WOOOOOOOOOOOOOO 🎉 🎉 🎉 🎉

ibrasho pushed a commit to ibrasho-forks/dep that referenced this pull request May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment