New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional windows symlink testing #495

Merged
merged 2 commits into from May 1, 2017

Conversation

Projects
None yet
3 participants
@ChrisHines
Copy link
Contributor

ChrisHines commented May 1, 2017

Fix for #494.

@googlebot googlebot added the cla: yes label May 1, 2017

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented May 1, 2017

LGTM, thank you! definitely much cleaner, and man do i love subtests

@sdboyer sdboyer merged commit bba3159 into golang:master May 1, 2017

4 checks passed

cla/google All necessary CLAs are signed
codeclimate no new or fixed issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChrisHines ChrisHines deleted the ChrisHines:optional-windows-symlink-testing branch May 2, 2017

ibrasho pushed a commit to ibrasho-forks/dep that referenced this pull request May 10, 2017

Merge pull request golang#495 from ChrisHines/optional-windows-symlin…
…k-testing

Optional windows symlink testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment