Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Better error reporting from dep ensure when packages have errors #844
What does this do / why do we need it?
Running dep ensure would generate unhelpful output when directories had code with errors or no go code. This prints the import path of the package with the build error message.
What should your reviewer look out for in this PR?
If you could make sure that my understanding of this functionality is correct, I'd appreciate it. As I noted in #814:
Do you need help or clarification on anything?
My integration tests run as I would expect them to run, but if you could make sure that this is a reasonable test, I'd greatly appreciate it!
Which issue(s) does this PR fix?
Hahahaha This is so funny and so sad. <3…
On Jul 19, 2017, at 8:33 PM, sam boyer ***@***.***> wrote: IT WENT THROUGH ok now tests — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Yeah. I took a look at the travis tests, and that's the integration test i wrote that seemed to be working fine but isn't. So, I'll have to unroll that. I still don't _quite_ understand the integration tests, i.e. how do I reproduce locally. If i run the test suite locally it passes so I have done something wrong somewhere.…
On Jul 20, 2017, at 5:22 PM, Ibrahim AshShohail ***@***.***> wrote: @grepory The error is from harness_tests ensure/pkg-errors/case2, you are expecting it to return an error, but it's not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@grepory yeah, it looks like that case2 might be a bit confused, as it has written outputs but is also expecting errors - that should generally be mutually exclusive. i think, i haven't reviewed in detail :/
running locally SHOULD just be a question of
referenced this pull request
Aug 5, 2017
like, that's the literal contents of the test file? i'm a bit surprised, but not too terribly so - in general, we do not require that your code be able to compile in order to run dep. we do static analysis, but (for now at least) we do very little - only into the imports (