From 7ed266ff48ca2cdd319b99a96cf3639115089b9b Mon Sep 17 00:00:00 2001 From: Sunny Date: Thu, 27 Jul 2017 11:16:53 +0530 Subject: [PATCH] fix(status): error out when lock not found `dep status` error out when no lock is found and suggest steps to generate lock file. Closes #891 --- cmd/dep/status.go | 3 +-- .../harness_tests/status/without_lock/final/Gopkg.toml | 0 .../harness_tests/status/without_lock/initial/Gopkg.toml | 0 .../harness_tests/status/without_lock/testcase.json | 6 ++++++ 4 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 cmd/dep/testdata/harness_tests/status/without_lock/final/Gopkg.toml create mode 100644 cmd/dep/testdata/harness_tests/status/without_lock/initial/Gopkg.toml create mode 100644 cmd/dep/testdata/harness_tests/status/without_lock/testcase.json diff --git a/cmd/dep/status.go b/cmd/dep/status.go index ce07f265b6..38183ff2ba 100644 --- a/cmd/dep/status.go +++ b/cmd/dep/status.go @@ -261,8 +261,7 @@ func runStatusAll(ctx *dep.Ctx, out outputter, p *dep.Project, sm gps.SourceMana var digestMismatch, hasMissingPkgs bool if p.Lock == nil { - // TODO if we have no lock file, do...other stuff - return digestMismatch, hasMissingPkgs, nil + return digestMismatch, hasMissingPkgs, errors.Errorf("no Gopkg.lock found. Run `dep ensure` to generate lock file") } // While the network churns on ListVersions() requests, statically analyze diff --git a/cmd/dep/testdata/harness_tests/status/without_lock/final/Gopkg.toml b/cmd/dep/testdata/harness_tests/status/without_lock/final/Gopkg.toml new file mode 100644 index 0000000000..e69de29bb2 diff --git a/cmd/dep/testdata/harness_tests/status/without_lock/initial/Gopkg.toml b/cmd/dep/testdata/harness_tests/status/without_lock/initial/Gopkg.toml new file mode 100644 index 0000000000..e69de29bb2 diff --git a/cmd/dep/testdata/harness_tests/status/without_lock/testcase.json b/cmd/dep/testdata/harness_tests/status/without_lock/testcase.json new file mode 100644 index 0000000000..5de8112840 --- /dev/null +++ b/cmd/dep/testdata/harness_tests/status/without_lock/testcase.json @@ -0,0 +1,6 @@ +{ + "commands": [ + ["status"] + ], + "error-expected": "no Gopkg.lock found. Run `dep ensure` to generate lock file" +}