dl: delete blank line from codereview.cfg #1
Conversation
dmitshur
added
the
cla: yes
dmitshur
changed the title
|
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134117. |
|
Message from Gerrit User 6005: Patch Set 2: This was a change created with the goal of testing that the new dl mirroring to GitHub works as expected. It seems to, although the first comment about the CL being created didn't show up. I'll look into that after. I suspect it's the same issue as golang/go#27504. I have the logs for when it happened, it might be helpful for the investigation. Please don’t reply on this GitHub thread. Visit golang.org/cl/134117. |
dmitshur
changed the title
|
This PR (HEAD: b41da79) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 12446: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134117. |
It's not needed. It's not there in other subrepos: - https://github.com/golang/image/blob/c73c2afc3b812cdd6385de5a50616511c4a3d458/codereview.cfg - https://github.com/golang/net/blob/161cd47e91fd58ac17490ef4d742dc98bb4cf60e/codereview.cfg Using this to test PRs for golang/go#26949.
|
This PR (HEAD: 51dbb14) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 12446: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134117. |
|
Message from Gerrit User 22285: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/134117. |
It's not needed. It's not there in other subrepos: - https://github.com/golang/image/blob/c73c2afc3b812cdd6385de5a50616511c4a3d458/codereview.cfg - https://github.com/golang/net/blob/161cd47e91fd58ac17490ef4d742dc98bb4cf60e/codereview.cfg Using this to test PRs for golang/go#26949. Change-Id: I7152ea2dae1a511928e787598696274cf2b315f9 GitHub-Last-Rev: 51dbb14 GitHub-Pull-Request: #1 Reviewed-on: https://go-review.googlesource.com/134117 Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
This PR is being closed because golang.org/cl/134117 has been merged. |
It's not needed. It's not there in other subrepos:
Using this to test PRs for golang/go#26949.