New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dl: delete blank line from codereview.cfg #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants

@dmitshur dmitshur added the cla: yes label Sep 7, 2018

@dmitshur dmitshur changed the title from remove blank line from codereview.cfg to dl: remove blank line from codereview.cfg Sep 7, 2018

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 7, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 7, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 7, 2018

Message from Gerrit User 6005:

Patch Set 2:

This was a change created with the goal of testing that the new dl mirroring to GitHub works as expected.

It seems to, although the first comment about the CL being created didn't show up. I'll look into that after. I suspect it's the same issue as golang/go#27504. I have the logs for when it happened, it might be helpful for the investigation.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 7, 2018

Message from Gerrit User 6005:

Patch Set 2:

This was a change created with the goal of testing that the new dl mirroring to GitHub works as expected.

It seems to, although the first comment about the CL being created didn't show up. I'll look into that after. I suspect it's the same issue as golang/go#27504. I have the logs for when it happened, it might be helpful for the investigation.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title from dl: remove blank line from codereview.cfg to dl: delete blank line from codereview.cfg Sep 10, 2018

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 10, 2018

This PR (HEAD: b41da79) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 10, 2018

This PR (HEAD: b41da79) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 10, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 10, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 10, 2018

This PR (HEAD: 51dbb14) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 10, 2018

This PR (HEAD: 51dbb14) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134117 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 10, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 10, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

Message from Gerrit User 22285:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 11, 2018

Message from Gerrit User 22285:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/134117.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 11, 2018

dl: delete blank line from codereview.cfg
It's not needed. It's not there in other subrepos:

- https://github.com/golang/image/blob/c73c2afc3b812cdd6385de5a50616511c4a3d458/codereview.cfg
- https://github.com/golang/net/blob/161cd47e91fd58ac17490ef4d742dc98bb4cf60e/codereview.cfg

Using this to test PRs for golang/go#26949.

Change-Id: I7152ea2dae1a511928e787598696274cf2b315f9
GitHub-Last-Rev: 51dbb14
GitHub-Pull-Request: golang/dl#1
Reviewed-on: https://go-review.googlesource.com/134117
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

This PR is being closed because golang.org/cl/134117 has been merged.

gopherbot commented Sep 11, 2018

This PR is being closed because golang.org/cl/134117 has been merged.

@gopherbot gopherbot closed this Sep 11, 2018

@dmitshur dmitshur deleted the dmitshur:rm-blank-line branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment