New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/version: simplify versionArchiveURL #2

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@dmitshur
Member

dmitshur commented Sep 10, 2018

versionArchiveURL always return nil error. It's unexported, so it's
easy to simplify it. If it needs to return an error in the future,
it can be changed accordingly at that time.

Also move goURL declaration just before use, rather than earlier.

internal/version: simplify versionArchiveURL
versionArchiveURL always return nil error. It's unexported, so it's easy to simplify it.
If it needs to return an error in the future, it can be changed accordingly at that time.

Also declare goURL just before use, rather than too early.

@googlebot googlebot added the cla: yes label Sep 10, 2018

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 10, 2018

This PR (HEAD: a609f1c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134435 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 10, 2018

This PR (HEAD: a609f1c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/134435 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

Message from Gerrit User 22285:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 11, 2018

Message from Gerrit User 22285:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

Message from Gerrit User 6005:

Patch Set 1: Run-TryBot+1

Testing to see what happens if I run a trybot here.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 11, 2018

Message from Gerrit User 6005:

Patch Set 1: Run-TryBot+1

Testing to see what happens if I run a trybot here.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b784bc6


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 11, 2018

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b784bc6


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 11, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134435.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 11, 2018

internal/version: simplify versionArchiveURL
versionArchiveURL always return nil error. It's unexported, so it's
easy to simplify it. If it needs to return an error in the future,
it can be changed accordingly at that time.

Also move goURL declaration just before use, rather than earlier.

Change-Id: I7f16e42b35852cb7bfb5b854e8be7a468e7efdde
GitHub-Last-Rev: a609f1c
GitHub-Pull-Request: golang/dl#2
Reviewed-on: https://go-review.googlesource.com/134435
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2018

This PR is being closed because golang.org/cl/134435 has been merged.

gopherbot commented Sep 11, 2018

This PR is being closed because golang.org/cl/134435 has been merged.

@gopherbot gopherbot closed this Sep 11, 2018

@dmitshur dmitshur deleted the dmitshur:simplify-versionArchiveURL branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment