Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny/driver/internal/win32: Close window correctly to be able to re-open one after closing #7

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@BaaaZen
Copy link
Contributor

commented Apr 13, 2019

This is an additional commit to
#6
https://go-review.googlesource.com/c/exp/+/171697

I forgot to add the modification of the syscall_windows.go that generates the zsyscall_windows.go. This is the missed change.

@googlebot googlebot added the cla: yes label Apr 13, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

This PR (HEAD: 393f268) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/171998 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/171998.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f9f9e0d8


Please don’t reply on this GitHub thread. Visit golang.org/cl/171998.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-amd64-race:
See https://storage.googleapis.com/go-build-log/f125b32d/linux-amd64-race_b99488e2.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171998.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

1 of 4 TryBots failed:
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/f125b32d/linux-amd64-race_b99488e2.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/171998.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 13, 2019

shiny/driver/internal/win32: Close window correctly to be able to re-…
…open one after closing

This is an additional commit to
#6
https://go-review.googlesource.com/c/exp/+/171697

I forgot to add the modification of the syscall_windows.go that generates the zsyscall_windows.go. This is the missed change.

Change-Id: Ib22037f5c51d3185dbc88cda12df9c2da55a895b
GitHub-Last-Rev: 393f268
GitHub-Pull-Request: #7
Reviewed-on: https://go-review.googlesource.com/c/exp/+/171998
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2019

This PR is being closed because golang.org/cl/171998 has been merged.

@gopherbot gopherbot closed this Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.