Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version on web pages #177

Open
nathany opened this Issue Jul 3, 2014 · 9 comments

Comments

Projects
None yet
4 participants
@nathany
Copy link
Contributor

nathany commented Jul 3, 2014

I noticed that the new favicon #167 and about page #158 changes aren't in production yet. It's hard to know what is deployed and what isn't... and therefore what is about to be deployed.

Something I find helpful is to have a production branch on GitHub that is merged to after a successful deploy. Then a simple compare would show what has accumulated on master but hasn't gone up.

production...master

@nf

This comment has been minimized.

Copy link
Contributor

nf commented Jul 6, 2014

I'd rather add a version string to the godoc.org HTML pages so that anyone can check.

@nf nf changed the title What's in production? Show version on web pages Jul 6, 2014

@nathany

This comment has been minimized.

Copy link
Contributor Author

nathany commented Jul 6, 2014

How would someone see what version of gddo is on GitHub but not yet deployed?
Does gddo already have a version, or would that need to be added?

The third alternative would be to deploy-on-merge (continuous deployment), usually via a CI server. But I don't believe gddo has any tests? Makes that proposition a little scary.

@nf

This comment has been minimized.

Copy link
Contributor

nf commented Jul 7, 2014

They'd look at https://github.com/golang/gddo and note the latest commit.
gddo doesn't have a version baked into it. would be pretty easy to do so, I think.

I'd like to move to continuous deployment. Tests are a must, of course.

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jul 7, 2014

What do you think about adding collaborators for this project, in order to help fix issues faster?

@nf

This comment has been minimized.

Copy link
Contributor

nf commented Jul 7, 2014

@shurcooL please create a new issue to discuss this.

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jul 7, 2014

On second thought, let's revisit this later. You've been reviewing and merging PRs quite actively lately, so I can stick to creating PRs via forks for the time being.

@nathany

This comment has been minimized.

Copy link
Contributor Author

nathany commented Jul 9, 2014

@nf Fyi, the "production" branch strategy is something I use to see what I'm deploying. The ability for others to easily see what isn't yet deployed yet is just a happy side effect.

I like the idea of embedding a version/SHA on the actual site though. I'm just not sure how to do it.

@nf

This comment has been minimized.

Copy link
Contributor

nf commented Jul 22, 2014

It would be part of the deployment process. Those scripts are in a private repository. Leave it to me.

@adg adg self-assigned this Sep 25, 2015

@adg adg removed their assignment Feb 14, 2018

@dmitshur dmitshur added the feature label Mar 14, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Mar 14, 2019

I'd rather add a version string to the godoc.org HTML pages so that anyone can check.

I agree with this approach.

Here's a mockup of what it can look like that @myitcv shared in #603 (comment):

Screen Shot 2019-03-14 at 13 08 20

@dmitshur dmitshur referenced this issue Mar 14, 2019

Open

all: deploy with Go 1.12 #603

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.