New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talks doesn't support .background #541

Closed
nezorflame opened this Issue Mar 14, 2018 · 13 comments

Comments

Projects
None yet
4 participants
@nezorflame

nezorflame commented Mar 14, 2018

Host any present slide with .background image.
It won't be shown for your presentation.
Other images seem to work fine.

Is this a bug or feature?

@dmitshur dmitshur added the talksapp label Mar 14, 2018

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 14, 2018

Member

Is this an issue with the present command? Or just talks.godoc.org?

Member

dmitshur commented Mar 14, 2018

Is this an issue with the present command? Or just talks.godoc.org?

@nezorflame

This comment has been minimized.

Show comment
Hide comment
@nezorflame

nezorflame commented Mar 16, 2018

Just talks.godoc.org

@nezorflame

This comment has been minimized.

Show comment
Hide comment
@nezorflame

nezorflame Mar 16, 2018

Background works fine when present is launched locally.

nezorflame commented Mar 16, 2018

Background works fine when present is launched locally.

@mmcloughlin

This comment has been minimized.

Show comment
Hide comment
@mmcloughlin

mmcloughlin Sep 4, 2018

Contributor

I'm seeing this too. There seems to be some re-processing of presentations happening which is not re-mapping .background URLs to point at github instead. See

gddo/gosrc/present.go

Lines 37 to 39 in 9d8ff1c

case "iframe", "image":
data = append(data, b.data[i:m[4]]...)
data = append(data, b.resolveURL(name)...)

Looks like this would not be too hard to fix.

Contributor

mmcloughlin commented Sep 4, 2018

I'm seeing this too. There seems to be some re-processing of presentations happening which is not re-mapping .background URLs to point at github instead. See

gddo/gosrc/present.go

Lines 37 to 39 in 9d8ff1c

case "iframe", "image":
data = append(data, b.data[i:m[4]]...)
data = append(data, b.resolveURL(name)...)

Looks like this would not be too hard to fix.

@mmcloughlin

This comment has been minimized.

Show comment
Hide comment
Contributor

mmcloughlin commented Sep 4, 2018

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 5, 2018

Member

@nezorflame (or anyone else), do you know of a sample talk that has a slide with .background that can be used to reproduce the bug?

Member

dmitshur commented Sep 5, 2018

@nezorflame (or anyone else), do you know of a sample talk that has a slide with .background that can be used to reproduce the bug?

@mmcloughlin

This comment has been minimized.

Show comment
Hide comment
@mmcloughlin
Contributor

mmcloughlin commented Sep 16, 2018

@Deleplace

This comment has been minimized.

Show comment
Hide comment
@Deleplace

Deleplace Sep 24, 2018

@mmcloughlin I read it and tested it locally, everything works fine on my workstation.

Deleplace commented Sep 24, 2018

@mmcloughlin I read it and tested it locally, everything works fine on my workstation.

@gopherbot gopherbot closed this in cd5c8e2 Oct 8, 2018

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 8, 2018

Member

The new version is deployed now, so .background should be working. Thank you for the contribution!

Member

dmitshur commented Oct 8, 2018

The new version is deployed now, so .background should be working. Thank you for the contribution!

@Deleplace

This comment has been minimized.

Show comment
Hide comment
@Deleplace

Deleplace Oct 8, 2018

Thank you @dmitshur . It now works fine on the public URL of my slideshow.

Deleplace commented Oct 8, 2018

Thank you @dmitshur . It now works fine on the public URL of my slideshow.

@mmcloughlin

This comment has been minimized.

Show comment
Hide comment
@mmcloughlin

mmcloughlin Oct 8, 2018

Contributor

We can also test this with the sample presentation that was also included in the CL. This was intended to exercise all possible features of the present tool.

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide

We do indeed see the .background correctly, however it seems the the vector graphic is broken.

Contributor

mmcloughlin commented Oct 8, 2018

We can also test this with the sample presentation that was also included in the CL. This was intended to exercise all possible features of the present tool.

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide

We do indeed see the .background correctly, however it seems the the vector graphic is broken.

@mmcloughlin

This comment has been minimized.

Show comment
Hide comment
@mmcloughlin

mmcloughlin Oct 8, 2018

Contributor

I'm getting a 403 from https://rawgit.com/golang/gddo/master/gosrc/testdata/gopher.svg

https://rawgit.com says "RawGit has reached the end of its useful life".

Contributor

mmcloughlin commented Oct 8, 2018

I'm getting a 403 from https://rawgit.com/golang/gddo/master/gosrc/testdata/gopher.svg

https://rawgit.com says "RawGit has reached the end of its useful life".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment