Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: deploy with Go 1.12 #603

Open
dmitshur opened this Issue Feb 28, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

dmitshur commented Feb 28, 2019

Now that Go 1.12 is out, gddo should be updated for it. This involves:

Previously #572 for Go 1.11.

/cc @andybons @shantuo @julieqiu

@dmitshur dmitshur added the operations label Feb 28, 2019

@dmitshur dmitshur self-assigned this Feb 28, 2019

gopherbot pushed a commit that referenced this issue Mar 1, 2019

gosrc: regenerate with Go 1.12
This change regenerates the list of standard packages to contain
packages that are in Go 1.12, which has been recently released.

It was done by running:

	go generate ./gosrc

Updates #603

Change-Id: I641eeb60c5a47feaa93dc1620ee9ad96ed6878ca
Reviewed-on: https://go-review.googlesource.com/c/164301
Reviewed-by: Tuo Shan <shantuo@google.com>
@myitcv

This comment has been minimized.

Copy link
Member

myitcv commented Mar 14, 2019

@dmitshur has this landed yet? (there doesn't appear to be a way from a godoc.org page to see what version of Go is in use)

Either way, there appears to be an issue with the search index again

Screen Shot 2019-03-14 at 11 16 28

Possibly a repeat of #508

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Mar 14, 2019

Thanks for reporting. The search index issue is a known consequence of the deploy not being done yet, as reflected by the status of this issue. It should be resolved when the deploy is done.

(there doesn't appear to be a way from a godoc.org page to see what version of Go is in use)

You’ll be able to tell when it’s done when https://godoc.org/cmd/go/internal/renameio displays package documentation rather than 404 (it’s a package that’s new to 1.12).

@myitcv

This comment was marked as resolved.

Copy link
Member

myitcv commented Mar 14, 2019

Thanks for confirming this issue is still outstanding.

You’ll be able to tell when it’s done when https://godoc.org/cmd/go/internal/renameio displays package documentation rather than 404 (it’s a package that’s new to 1.12).

Perhaps a slightly more robust way of determining the Go version being "run" by godoc.org would be to include the version string in the page footer?

Screen Shot 2019-03-14 at 13 08 20

@dmitshur

This comment was marked as resolved.

Copy link
Member Author

dmitshur commented Mar 14, 2019

Perhaps a slightly more robust way of determining the Go version being "run" by godoc.org would be to include the version string in the page footer?

I agree, that would be a helpful feature. There's already an open issue tracking it, see #177. I've added your picture illustrating what it can look like there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.