Skip to content
This repository has been archived by the owner. It is now read-only.

GoDoc.org shows out of date package github:temporalio/temporal-go-sdk #688

Closed
flossypurse opened this issue Sep 3, 2020 · 3 comments
Closed

Comments

@flossypurse
Copy link

@flossypurse flossypurse commented Sep 3, 2020

What is the URL of the page with the issue?

https://godoc.org/github.com/temporalio/temporal-go-sdk

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Screenshot

Screen Shot 2020-09-03 at 2 31 52 PM

What did you do?

Searched for "temporal go sdk"

What did you expect to see?

The up-to-date package github.com:temporalio/go-sdk
The up-to-date package is available via pkg.go.dev: https://pkg.go.dev/go.temporal.io/sdk

What did you see instead?

This package no longer exists (github.com:temporalio/temporal-go-sdk)
We don't want the old out-of-date package to be published.

@dmitshur dmitshur transferred this issue from golang/go Sep 3, 2020
@dmitshur dmitshur changed the title x/pkgsite: GoDocs.org shows out of date package github:temporalio/temporal-go-sdk GoDoc.org shows out of date package github:temporalio/temporal-go-sdk Sep 3, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Sep 3, 2020

The repository at https://github.com/temporalio/temporal-go-sdk exists.

The problem here is that godoc.org is not module aware, so it doesn't know to read the go.mod file, where it's stated that the canonical import path is go.temporal.io/sdk rather than github.com/temporalio/temporal-go-sdk.

/cc @julieqiu

@flossypurse
Copy link
Author

@flossypurse flossypurse commented Sep 8, 2020

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jan 15, 2021

OK, so how do we "fix" that?

There's nothing you need to do, this was fixed by making a module-aware package documentation available at pkg.go.dev, where as you said this works. Considering https://blog.golang.org/godoc.org-redirect, I don't think there's anything more to do here.

@dmitshur dmitshur closed this Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants