New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gddo-server: fix expanding examples containing reserved characters #581

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jackwilsdon

jackwilsdon commented Sep 16, 2018

The href attribute is percent-encoded by html/template, which ends up
breaking how Bootstrap links the heading to it's target. We can instead
use data-target to explicitly name the target, without it being
percent-encoded.

Fixes #570

@googlebot googlebot added the cla: yes label Sep 16, 2018

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

This PR (HEAD: 340e2d4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 16, 2018

This PR (HEAD: 340e2d4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 16, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

This PR (HEAD: dfc65a6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 16, 2018

This PR (HEAD: dfc65a6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gddo-server: fix expanding examples containing reserved characters
The href attribute is percent-encoded by html/template, which ends up
breaking how Bootstrap links the heading to it's target. We can instead
use data-target to explicitly name the target, without it being
percent-encoded.

Fixes #570
@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

This PR (HEAD: 7372e70) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Sep 16, 2018

This PR (HEAD: 7372e70) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

@jackwilsdon jackwilsdon changed the title from gddo-server: fix accordion for encoded examples to gddo-server: fix expanding examples containing reserved characters Sep 16, 2018

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Sep 16, 2018

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135536.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment