New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talksapp: use Go 1.9, update bot.html URLs #590

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@dmitshur
Member

dmitshur commented Nov 16, 2018

Go 1.8 isn't supported anymore by goapp test (which is run by Travis CI).

Also add deploy command to README.

talksapp: use Go 1.9, update bot.html URLs
Go 1.8 isn't supported anymore by goapp test (which is run by Travis CI).

Also add deploy command to README.

Change-Id: I969788d1f753303a76b9d609136737decf97a00a

@googlebot googlebot added the cla: yes label Nov 16, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Nov 16, 2018

This PR (HEAD: af88a3b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/150059 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

gopherbot commented Nov 16, 2018

Message from Dmitri Shuralyov:

Patch Set 1:

This fixes Travis CI, see #590.


Please don’t reply on this GitHub thread. Visit golang.org/cl/150059.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

gopherbot commented Nov 16, 2018

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/150059.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 16, 2018

talksapp: use Go 1.9, update bot.html URLs
Go 1.8 isn't supported anymore by goapp test (which is run by Travis CI).

Also add deploy command to README.

Change-Id: I90ee9a699fd95c74ce51446dbc35533738c05eea
GitHub-Last-Rev: af88a3b
GitHub-Pull-Request: #590
Reviewed-on: https://go-review.googlesource.com/c/150059
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Nov 16, 2018

This PR is being closed because golang.org/cl/150059 has been merged.

@gopherbot gopherbot closed this Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment