Permalink
Browse files

cmd/dist: skip moved GOROOT on Go's Windows builders when not shardin…

…g tests

Change-Id: I0bcae339624e7d61037d9ea0885b7bd07491bbb6
Reviewed-on: https://go-review.googlesource.com/51430
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information...
bradfitz committed Jul 27, 2017
1 parent e157fac commit 45a4609c0ae214e448612e0bc0846e2f2682f1b2
Showing with 11 additions and 0 deletions.
  1. +11 −0 src/cmd/dist/test.go
View
@@ -447,6 +447,17 @@ func (t *tester) registerTests() {
t.runPending(dt)
moved := t.goroot + "-moved"
if err := os.Rename(t.goroot, moved); err != nil {
if t.goos == "windows" {
// Fails on Windows (with "Access is denied") if a process
// or binary is in this directory. For instance, using all.bat
// when run from c:\workdir\go\src fails here
// if GO_BUILDER_NAME is set. Our builders invoke tests
// a different way which happens to work when sharding
// tests, but we should be tolerant of the non-sharded
// all.bat case.
log.Printf("skipping test on Windows")
return nil
}
return err
}

0 comments on commit 45a4609

Please sign in to comment.