Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/compile: fix stenciling of conversions between interfaces
Conversions need to allow nil through. We do that using a CONVIFACE instead of a DOTTYPE. Also reorganize how nonempty interfaces are handled. For nonempty to empty, a simple CONVIFACE suffices. For nonempty to nonempty, we need to call the runtime to get the new itab. Use the entry from the dictionary to identify the target interface type (if parameterized). Fixes #47925 Change-Id: I4ffeed964318bb3e270b06f558e6ab9c5bfc7188 Reviewed-on: https://go-review.googlesource.com/c/go/+/344830 Trust: Keith Randall <khr@golang.org> Trust: Dan Scales <danscales@google.com> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
- Loading branch information
Showing
6 changed files
with
187 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// run -gcflags=-G=3 | ||
|
||
// Copyright 2021 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
type myifacer[T any] interface{ do(T) error } | ||
|
||
type stuff[T any] struct{} | ||
|
||
func (s stuff[T]) run() interface{} { | ||
var i myifacer[T] | ||
return i | ||
} | ||
|
||
func main() { | ||
stuff[int]{}.run() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// run -gcflags=-G=3 | ||
|
||
// Copyright 2021 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
type I[T any] interface { | ||
foo() | ||
} | ||
|
||
type E[T any] interface { | ||
} | ||
|
||
//go:noinline | ||
func f[T I[T]](x T) E[T] { | ||
// contains a cast from nonempty to empty interface | ||
return E[T](I[T](x)) | ||
} | ||
|
||
type S struct { | ||
x int | ||
} | ||
|
||
func (s *S) foo() {} | ||
|
||
func main() { | ||
i := f(&S{x: 7}) | ||
if i.(*S).x != 7 { | ||
panic("bad") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// run -gcflags=-G=3 | ||
|
||
// Copyright 2021 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
type I[T any] interface { | ||
foo() | ||
} | ||
|
||
type J[T any] interface { | ||
foo() | ||
bar() | ||
} | ||
|
||
//go:noinline | ||
func f[T J[T]](x T) I[T] { | ||
// contains a cast between two nonempty interfaces | ||
return I[T](J[T](x)) | ||
} | ||
|
||
type S struct { | ||
x int | ||
} | ||
|
||
func (s *S) foo() {} | ||
func (s *S) bar() {} | ||
|
||
func main() { | ||
i := f(&S{x: 7}) | ||
if i.(*S).x != 7 { | ||
panic("bad") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// run -gcflags=-G=3 | ||
|
||
// Copyright 2021 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
type I[T any] interface { | ||
foo() | ||
} | ||
|
||
type J[T any] interface { | ||
foo() | ||
bar() | ||
} | ||
|
||
//go:noinline | ||
func f[T J[T]](x T, g func(T) T) I[T] { | ||
// contains a cast between two nonempty interfaces | ||
// Also make sure we don't evaluate g(x) twice. | ||
return I[T](J[T](g(x))) | ||
} | ||
|
||
type S struct { | ||
x int | ||
} | ||
|
||
func (s *S) foo() {} | ||
func (s *S) bar() {} | ||
|
||
var cnt int | ||
|
||
func inc(s *S) *S { | ||
cnt++ | ||
return s | ||
} | ||
|
||
func main() { | ||
i := f(&S{x: 7}, inc) | ||
if i.(*S).x != 7 { | ||
panic("bad") | ||
} | ||
if cnt != 1 { | ||
panic("multiple calls") | ||
} | ||
} |