From 6fe8ee78e9b4870ebc1de2b5cfd6170a78a56c00 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Fri, 2 Nov 2018 22:21:23 -0700 Subject: [PATCH] cmd/compile/internal/gc: remove isforw predicate table (cleanup) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Was only ever filled with one Etype (TFORW) and only used in one place. Easier to just check for TFORW. Change-Id: Icc96da3a22b0af1d7e60bc5841c744916c53341e Reviewed-on: https://go-review.googlesource.com/c/147285 Reviewed-by: Martin Möhrmann --- src/cmd/compile/internal/gc/go.go | 1 - src/cmd/compile/internal/gc/reflect.go | 2 +- src/cmd/compile/internal/gc/universe.go | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/cmd/compile/internal/gc/go.go b/src/cmd/compile/internal/gc/go.go index cfd695097f86b..471746ed7dde2 100644 --- a/src/cmd/compile/internal/gc/go.go +++ b/src/cmd/compile/internal/gc/go.go @@ -147,7 +147,6 @@ var asmhdr string var simtype [NTYPE]types.EType var ( - isforw [NTYPE]bool isInt [NTYPE]bool isFloat [NTYPE]bool isComplex [NTYPE]bool diff --git a/src/cmd/compile/internal/gc/reflect.go b/src/cmd/compile/internal/gc/reflect.go index e4008bd7e7642..415d3cd5948b7 100644 --- a/src/cmd/compile/internal/gc/reflect.go +++ b/src/cmd/compile/internal/gc/reflect.go @@ -1137,7 +1137,7 @@ func dtypesym(t *types.Type) *obj.LSym { return lsym } // TODO(mdempsky): Investigate whether this can happen. - if isforw[tbase.Etype] { + if tbase.Etype == TFORW { return lsym } } diff --git a/src/cmd/compile/internal/gc/universe.go b/src/cmd/compile/internal/gc/universe.go index 96980ad500d57..760a8e40b0f5b 100644 --- a/src/cmd/compile/internal/gc/universe.go +++ b/src/cmd/compile/internal/gc/universe.go @@ -200,8 +200,6 @@ func typeinit() { isComplex[TCOMPLEX64] = true isComplex[TCOMPLEX128] = true - isforw[TFORW] = true - // initialize okfor for et := types.EType(0); et < NTYPE; et++ { if isInt[et] || et == TIDEAL {