From 83e839f86fcc0762ea513f8d5dd9a50a8338e9c2 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Fri, 24 Jun 2016 13:19:46 -0700 Subject: [PATCH] cmd/pprof: ignore symbols with address 0 and size 0 Handling a symbol with address 0 and size 0, such as an ELF STT_FILE symbols, was causing us to disassemble the entire program. We started adding STT_FILE symbols to help fix issue #13247. Fixes #16154. Change-Id: I174b9614e66ddc3d65801f7c1af7650f291ac2af Reviewed-on: https://go-review.googlesource.com/24460 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Joe Tsai --- src/cmd/pprof/pprof.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/pprof/pprof.go b/src/cmd/pprof/pprof.go index 5c243d2a587bf..feccd1227b750 100644 --- a/src/cmd/pprof/pprof.go +++ b/src/cmd/pprof/pprof.go @@ -308,6 +308,11 @@ func (f *file) Symbols(r *regexp.Regexp, addr uint64) ([]*plugin.Sym, error) { } var out []*plugin.Sym for _, s := range f.sym { + // Ignore a symbol with address 0 and size 0. + // An ELF STT_FILE symbol will look like that. + if s.Addr == 0 && s.Size == 0 { + continue + } if (r == nil || r.MatchString(s.Name)) && (addr == 0 || s.Addr <= addr && addr < s.Addr+uint64(s.Size)) { out = append(out, &plugin.Sym{ Name: []string{s.Name},