From cb97fd7741fc8bfa257bb020dab756a14c420daf Mon Sep 17 00:00:00 2001 From: Michael Hudson-Doyle Date: Fri, 29 Apr 2016 10:37:37 +1200 Subject: [PATCH] cmd/link: fix -no-pie / -race check golang.org/cl/22453 was supposed to pass -no-pie to the linker when linking a race-enabled binary if the host toolchain supports it. But I bungled the supported check as I forgot to pass -c to the host compiler so it tried to compile a 0 byte .c file into an executable, which will never work. Fix it to pass -c as it should have all along. Change-Id: I4801345c7a29cb18d5f22cec5337ce535f92135d Reviewed-on: https://go-review.googlesource.com/22587 Run-TryBot: Michael Hudson-Doyle TryBot-Result: Gobot Gobot Reviewed-by: Minux Ma --- src/cmd/link/internal/ld/lib.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 53428bb1c6f45..f6c7a0152bb67 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -1213,7 +1213,7 @@ func hostlink() { if err := ioutil.WriteFile(src, []byte{}, 0666); err != nil { Ctxt.Diag("WriteFile trivial.c failed: %v", err) } - cmd := exec.Command(argv[0], "-no-pie", "trivial.c") + cmd := exec.Command(argv[0], "-c", "-no-pie", "trivial.c") cmd.Dir = tmpdir out, err := cmd.CombinedOutput() supported := err == nil && !bytes.Contains(out, []byte("unrecognized"))