Skip to content

Commit

Permalink
cmd/dist: test cgo internal linking on darwin-arm64
Browse files Browse the repository at this point in the history
CL 383554 disables testing cgo internal linking on all ARM64 but
Windows, because it doesn't work with newer GCC. But
- darwin-arm64 works, and it does not use GCC
- we don't support cgo internal linking on windows-arm64 anyway.

This CL fixes the condition.

Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432
Reviewed-on: https://go-review.googlesource.com/c/go/+/384269
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
cherrymui committed Feb 8, 2022
1 parent 6749dd4 commit e4ca3fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cmd/dist/test.go
Expand Up @@ -1119,7 +1119,7 @@ func (t *tester) cgoTest(dt *distTest) error {

// Skip internal linking cases on arm64 to support GCC-9.4 and above.
// See issue #39466.
skipInternalLink := goarch == "arm64" && goos != "windows"
skipInternalLink := goarch == "arm64" && goos != "darwin"

if t.internalLink() && !skipInternalLink {
cmd := t.addCmd(dt, "misc/cgo/test", t.goTest(), "-tags=internal")
Expand Down

0 comments on commit e4ca3fa

Please sign in to comment.