Skip to content
Permalink
Branch: master
Commits on Aug 9, 2019
  1. doc/install-source.html: add new GOOS and GOARCHes

    agnivade committed Aug 9, 2019
    And also insert new paragraphs between GOOS and GOARCH listings
    for better readability.
    
    Fixes #28142
    Fixes #26513
    
    Change-Id: Ie92e98dbfd924e80032a12afbfa02f30e3a6f916
    Reviewed-on: https://go-review.googlesource.com/c/go/+/189578
    Reviewed-by: Andrew Bonventre <andybons@golang.org>
Commits on Aug 3, 2019
  1. doc/go1.13: add release notes for GOWASM environment variable

    agnivade committed Aug 2, 2019
    Change-Id: I103a21ae0be8feb9447fa277483b7c2a8b5807e7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/188540
    Reviewed-by: Andrew Bonventre <andybons@golang.org>
    Reviewed-by: Richard Musiol <neelance@gmail.com>
Commits on Jul 8, 2019
  1. Revert "go/parser: include more comments in a struct or interface"

    agnivade authored and griesemer committed Jul 8, 2019
    This reverts commit https://golang.org/cl/161177/.
    
    Reason for revert: this led to non-contiguous comments spaced
    by an empty line to be grouped into a single CommentGroup
    
    Fixes #32944
    Updates #10858
    
    Change-Id: I5e16663b308c3b560496da8e66c33befdf9ed9dd
    Reviewed-on: https://go-review.googlesource.com/c/go/+/185040
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Jun 4, 2019
  1. doc: fix missing anchor links in contribute.html

    agnivade committed Jun 4, 2019
    Some <h3>s were missing ids due to which the anchor links
    weren't getting generated.
    
    Fixes #32415
    
    Change-Id: Ica21425c1a7c49735231c1de96b6c77dd594ce64
    Reviewed-on: https://go-review.googlesource.com/c/go/+/180397
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
Commits on May 25, 2019
  1. cmd/doc: display a proper error when no packages are found

    agnivade authored and robpike committed May 25, 2019
    Fixes #32044
    
    Change-Id: Ia220dbbe4d6851befe28dd2d4b8a1a7bc2757460
    Reviewed-on: https://go-review.googlesource.com/c/go/+/178878
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
Commits on May 23, 2019
  1. cmd/doc: stop showing interface methods while matching symbols

    agnivade authored and robpike committed May 22, 2019
    Fixes #31961
    
    Change-Id: I9db9ecfd2f8ca7cf51df4413a6e0d66de5da7043
    Reviewed-on: https://go-review.googlesource.com/c/go/+/178457
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
Commits on May 22, 2019
  1. net/url: clarify that RawPath is optionally set

    agnivade authored and bradfitz committed May 21, 2019
    Fixes #29662
    
    Change-Id: I38b52b96712e44a323333da17dbbc883516773b6
    Reviewed-on: https://go-review.googlesource.com/c/go/+/177900
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Apr 2, 2019
  1. image/jpeg: reduce bound checks from idct and fdct

    agnivade authored and nigeltao committed Jan 7, 2019
    Before -
    $gotip build -gcflags="-d=ssa/check_bce/debug=1" fdct.go idct.go
    ./fdct.go:89:10: Found IsInBounds
    ./fdct.go:90:10: Found IsInBounds
    ./fdct.go:91:10: Found IsInBounds
    ./fdct.go:92:10: Found IsInBounds
    ./fdct.go:93:10: Found IsInBounds
    ./fdct.go:94:10: Found IsInBounds
    ./fdct.go:95:10: Found IsInBounds
    ./fdct.go:96:10: Found IsInBounds
    ./idct.go:77:9: Found IsInBounds
    ./idct.go:77:27: Found IsInBounds
    ./idct.go:77:45: Found IsInBounds
    ./idct.go:78:7: Found IsInBounds
    ./idct.go:78:25: Found IsInBounds
    ./idct.go:78:43: Found IsInBounds
    ./idct.go:78:61: Found IsInBounds
    ./idct.go:79:13: Found IsInBounds
    ./idct.go:92:13: Found IsInBounds
    ./idct.go:93:12: Found IsInBounds
    ./idct.go:94:12: Found IsInBounds
    ./idct.go:95:12: Found IsInBounds
    ./idct.go:97:12: Found IsInBounds
    ./idct.go:98:12: Found IsInBounds
    ./idct.go:99:12: Found IsInBounds
    
    After -
    $gotip build -gcflags="-d=ssa/check_bce/debug=1" fdct.go idct.go
    ./fdct.go:90:9: Found IsSliceInBounds
    ./idct.go:76:11: Found IsSliceInBounds
    ./idct.go:145:11: Found IsSliceInBounds
    
    name                 old time/op    new time/op    delta
    FDCT-4                 1.85µs ± 2%    1.74µs ± 1%  -5.95%  (p=0.000 n=10+10)
    IDCT-4                 1.94µs ± 2%    1.89µs ± 1%  -2.67%  (p=0.000 n=10+9)
    DecodeBaseline-4       1.45ms ± 2%    1.46ms ± 1%    ~     (p=0.156 n=9+10)
    DecodeProgressive-4    2.21ms ± 1%    2.21ms ± 1%    ~     (p=0.796 n=10+10)
    EncodeRGBA-4           24.9ms ± 1%    25.0ms ± 1%    ~     (p=0.075 n=10+10)
    EncodeYCbCr-4          26.1ms ± 1%    26.2ms ± 1%    ~     (p=0.573 n=8+10)
    
    name                 old speed      new speed      delta
    DecodeBaseline-4     42.5MB/s ± 2%  42.4MB/s ± 1%    ~     (p=0.162 n=9+10)
    DecodeProgressive-4  27.9MB/s ± 1%  27.9MB/s ± 1%    ~     (p=0.796 n=10+10)
    EncodeRGBA-4         49.4MB/s ± 1%  49.1MB/s ± 1%    ~     (p=0.066 n=10+10)
    EncodeYCbCr-4        35.3MB/s ± 1%  35.2MB/s ± 1%    ~     (p=0.586 n=8+10)
    
    name                 old alloc/op   new alloc/op   delta
    DecodeBaseline-4       63.0kB ± 0%    63.0kB ± 0%    ~     (all equal)
    DecodeProgressive-4     260kB ± 0%     260kB ± 0%    ~     (all equal)
    EncodeRGBA-4           4.40kB ± 0%    4.40kB ± 0%    ~     (all equal)
    EncodeYCbCr-4          4.40kB ± 0%    4.40kB ± 0%    ~     (all equal)
    
    name                 old allocs/op  new allocs/op  delta
    DecodeBaseline-4         5.00 ± 0%      5.00 ± 0%    ~     (all equal)
    DecodeProgressive-4      13.0 ± 0%      13.0 ± 0%    ~     (all equal)
    EncodeRGBA-4             4.00 ± 0%      4.00 ± 0%    ~     (all equal)
    EncodeYCbCr-4            4.00 ± 0%      4.00 ± 0%    ~     (all equal)
    
    Updates #24499
    
    Change-Id: I6828d077b851817503a7c1a08235763f81bdadf9
    Reviewed-on: https://go-review.googlesource.com/c/go/+/167417
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Nigel Tao <nigeltao@golang.org>
Commits on Mar 29, 2019
  1. internal/bytealg: simplify memchr for wasm

    agnivade committed Mar 27, 2019
    Get rid of an extra register R5 which just recalculated the value of R4.
    Reuse R4 instead.
    
    We also remove the casting of c to an unsigned char because the initial
    load of R0 is done with I32Load8U anyways.
    
    Also indent the code to make it more readable.
    
    name                           old time/op  new time/op  delta
    IndexRune                       597ns ± 3%   580ns ± 3%  -2.93%  (p=0.002 n=10+10)
    IndexRuneLongString             634ns ± 4%   654ns ± 3%  +3.07%  (p=0.004 n=10+10)
    IndexRuneFastPath              57.6ns ± 3%  56.9ns ± 4%    ~     (p=0.210 n=10+10)
    Index                           104ns ± 3%   104ns ± 4%    ~     (p=0.639 n=10+10)
    LastIndex                      87.1ns ± 5%  85.7ns ± 3%    ~     (p=0.171 n=10+10)
    IndexByte                      34.4ns ± 4%  32.9ns ± 5%  -4.28%  (p=0.002 n=10+10)
    IndexHard1                     21.6ms ± 1%  21.8ms ± 3%    ~     (p=0.460 n=8+10)
    IndexHard2                     21.6ms ± 2%  21.9ms ± 5%    ~     (p=0.133 n=9+10)
    IndexHard3                     21.8ms ± 3%  21.7ms ± 1%    ~     (p=0.579 n=10+10)
    IndexHard4                     21.6ms ± 1%  21.9ms ± 4%    ~     (p=0.360 n=8+10)
    LastIndexHard1                 25.1ms ± 2%  25.4ms ± 5%    ~     (p=0.853 n=10+10)
    LastIndexHard2                 25.3ms ± 6%  25.2ms ± 5%    ~     (p=0.796 n=10+10)
    LastIndexHard3                 25.3ms ± 4%  25.2ms ± 3%    ~     (p=0.739 n=10+10)
    IndexTorture                    130µs ± 3%   133µs ± 5%    ~     (p=0.218 n=10+10)
    IndexAnyASCII/1:1              98.4ns ± 5%  96.6ns ± 5%    ~     (p=0.054 n=10+10)
    IndexAnyASCII/1:2               109ns ± 4%   110ns ± 3%    ~     (p=0.232 n=10+10)
    IndexAnyASCII/1:4               135ns ± 4%   134ns ± 3%    ~     (p=0.671 n=10+10)
    IndexAnyASCII/1:8               184ns ± 4%   184ns ± 3%    ~     (p=0.749 n=10+10)
    IndexAnyASCII/1:16              289ns ± 3%   281ns ± 3%  -2.73%  (p=0.001 n=9+10)
    IndexAnyASCII/16:1              322ns ± 3%   307ns ± 3%  -4.71%  (p=0.000 n=10+10)
    IndexAnyASCII/16:2              329ns ± 3%   320ns ± 3%  -2.89%  (p=0.008 n=10+10)
    IndexAnyASCII/16:4              353ns ± 3%   339ns ± 3%  -3.91%  (p=0.001 n=10+10)
    IndexAnyASCII/16:8              390ns ± 3%   374ns ± 3%  -4.06%  (p=0.000 n=10+10)
    IndexAnyASCII/16:16             471ns ± 4%   452ns ± 2%  -4.22%  (p=0.000 n=10+10)
    IndexAnyASCII/256:1            2.94µs ± 4%  2.91µs ± 2%    ~     (p=0.424 n=10+10)
    IndexAnyASCII/256:2            2.92µs ± 3%  2.90µs ± 2%    ~     (p=0.388 n=9+10)
    IndexAnyASCII/256:4            2.93µs ± 1%  2.90µs ± 1%  -0.98%  (p=0.036 n=8+9)
    IndexAnyASCII/256:8            3.03µs ± 5%  2.97µs ± 3%    ~     (p=0.085 n=10+10)
    IndexAnyASCII/256:16           3.07µs ± 4%  3.01µs ± 1%  -2.03%  (p=0.003 n=10+9)
    IndexAnyASCII/4096:1           45.8µs ± 3%  45.9µs ± 2%    ~     (p=0.905 n=10+9)
    IndexAnyASCII/4096:2           46.7µs ± 3%  46.2µs ± 3%    ~     (p=0.190 n=10+10)
    IndexAnyASCII/4096:4           45.7µs ± 2%  46.4µs ± 3%  +1.37%  (p=0.022 n=9+10)
    IndexAnyASCII/4096:8           46.4µs ± 3%  46.0µs ± 2%    ~     (p=0.436 n=10+10)
    IndexAnyASCII/4096:16          46.6µs ± 3%  46.7µs ± 2%    ~     (p=0.971 n=10+10)
    IndexPeriodic/IndexPeriodic2   1.40ms ± 3%  1.40ms ± 2%    ~     (p=0.853 n=10+10)
    IndexPeriodic/IndexPeriodic4   1.40ms ± 3%  1.40ms ± 3%    ~     (p=0.579 n=10+10)
    IndexPeriodic/IndexPeriodic8   1.42ms ± 3%  1.39ms ± 2%  -1.60%  (p=0.029 n=10+10)
    IndexPeriodic/IndexPeriodic16   616µs ± 5%   583µs ± 5%  -5.32%  (p=0.001 n=10+10)
    IndexPeriodic/IndexPeriodic32   313µs ± 5%   301µs ± 2%  -3.67%  (p=0.002 n=10+10)
    IndexPeriodic/IndexPeriodic64   169µs ± 5%   164µs ± 5%  -3.17%  (p=0.023 n=10+10)
    
    NodeJS version - 10.2.1
    
    Change-Id: I9a8268314b5652c4aeffc4c5c72d2fd1a384aa9e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/169777
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Cherry Zhang <cherryyz@google.com>
Commits on Mar 28, 2019
  1. go/ast: fix SortImports to handle block comments

    agnivade authored and griesemer committed Feb 13, 2019
    The current algorithm only assumed line comments which always
    appear at the end of an import spec. This caused block comments
    which can appear before a spec to be attached to the previous spec.
    
    So while mapping a comment to an import spec, we maintain additional
    information on whether the comment is supposed to appear on the left
    or right of the spec.
    
    And we also take into account the possibility of "//line" comments
    in the source. So we use unadjusted line numbers.
    
    While at it, added some more testcases from tools/go/ast/astutil/imports_test.go
    
    Fixes #18929
    
    Change-Id: If920426641702a8a93904b2ec1d3455749169f69
    Reviewed-on: https://go-review.googlesource.com/c/go/+/162337
    Run-TryBot: Robert Griesemer <gri@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Mar 27, 2019
  1. cmd/go/internal/{run,work,generate}: document file path location requ…

    agnivade committed Nov 15, 2018
    …irement
    
    Mention that .go files must be from a single directory
    for them to be treated as a single package.
    
    Fixes #21529
    
    Change-Id: I79cb08b9f43888814b1249a7b50bc7bc70bc1c72
    Reviewed-on: https://go-review.googlesource.com/c/go/+/149797
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Commits on Mar 13, 2019
  1. testing/cover: improve message when a package has no statements

    agnivade committed Dec 23, 2018
    Fixes #25492
    
    Change-Id: Ic1496857524dad0c0a77f3bb80fa084c9bf00aa9
    Reviewed-on: https://go-review.googlesource.com/c/go/+/155777
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
Commits on Mar 8, 2019
  1. cmd/doc: add a line gap after a method with no comment

    agnivade committed Mar 8, 2019
    Fixes #30492
    
    Change-Id: Iec658bdf8bfac21e1bcc3eed900722cc535ec00a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/166178
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
Commits on Mar 6, 2019
  1. go/parser: include more comments in a struct or interface

    agnivade authored and griesemer committed Feb 4, 2019
    While parsing inside a struct or an interface, skipping over empty lines
    too to collect the next group of comments. We do not need to skip
    over more than 1 empty line since gofmt already removes multiple
    empty consecutive lines.
    
    Fixes #10858
    
    Change-Id: I0c97b65b5fc44e225e5dc7871ace24f43419ce08
    Reviewed-on: https://go-review.googlesource.com/c/go/+/161177
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Mar 5, 2019
  1. go/doc: add // while wrapping a line comment in ToText

    agnivade authored and griesemer committed Feb 20, 2019
    Currently, lineWrapper does not detect if it is printing a line comment or not.
    Hence, while wrapping a comment, the new line does not get prefixed with a //.
    
    We add logic to lineWrapper to detect this case and add // accordingly. Block
    comments do not need any such handling.
    
    Added tests for both cases.
    
    Fixes #20929
    
    Change-Id: I656037c2d865f31dd853cf9195f43ab7c6e6fc53
    Reviewed-on: https://go-review.googlesource.com/c/go/+/163578
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Mar 4, 2019
  1. misc/git: remove pre-commit file

    agnivade committed Jan 19, 2019
    All hook files are automatically set up when any git-codereview command is run.
    And since the contribution guidelines point to installing git-codereview,
    this file does not serve any purpose any more.
    
    Change-Id: I165f6905ca03fd3d512c59e2654ef79e76de934c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/158677
    Reviewed-by: Andrew Bonventre <andybons@golang.org>
Commits on Mar 2, 2019
  1. bufio: fix emptyFinalToken example to handle multiple Reads

    agnivade committed Jan 14, 2019
    Fixes #25909
    
    Change-Id: I9a53a1a06aab5d1877a8e9b1b8b782d77d6027a8
    Reviewed-on: https://go-review.googlesource.com/c/157758
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Feb 27, 2019
  1. syscall/js: add a note about a bug in TypedArray

    agnivade authored and mvdan committed Dec 26, 2018
    Fixes #29355
    
    Change-Id: I4018d420c8d413b2681744af18ffb65da03ac504
    Reviewed-on: https://go-review.googlesource.com/c/155778
    Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Richard Musiol <neelance@gmail.com>
Commits on Feb 26, 2019
  1. go/doc: skip escaping comments in pre-formatted blocks

    agnivade authored and mvdan committed Feb 18, 2019
    CL 150377 made the change of converting smart quotes to their html escaped entities
    for ToHTML, and to unicode quotes for ToText. But for ToText, the change
    converted the quotes in pre-formatted text too.
    
    This fixes that behavior to not touch any text in pre-formatted blocks, which also
    makes the behavior consistent with ToHTML.
    
    Fixes #29730
    
    Change-Id: I58e0216cbdbe189d06d82147e5a02b620af14734
    Reviewed-on: https://go-review.googlesource.com/c/162922
    Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
  2. cmd/compile: fix a typo in assignment mismatch error

    agnivade authored and mvdan committed Feb 7, 2019
    Fixes #30087
    
    Change-Id: Ic6d80f8e6e1831886af8613420b1bd129a1b4850
    Reviewed-on: https://go-review.googlesource.com/c/161577
    Reviewed-by: Robert Griesemer <gri@golang.org>
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jan 2, 2019
  1. net/url: clarify documentation about (*URL).String

    agnivade authored and bradfitz committed Dec 21, 2018
    Fixes #23669
    
    Change-Id: Ib7f0aab0b066f778a3097583f432f8092310fb81
    Reviewed-on: https://go-review.googlesource.com/c/155598
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Dec 19, 2018
  1. doc/go1.12: fix minor grammatical error

    agnivade authored and ianlancetaylor committed Dec 19, 2018
    Change-Id: I767bf77aeab62f2d42239fac9d601a8e04fe860f
    Reviewed-on: https://go-review.googlesource.com/c/154957
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
Commits on Dec 16, 2018
  1. go/doc: handle Examples with no body

    agnivade authored and griesemer committed Dec 16, 2018
    Fixes #29271
    
    Change-Id: Iff6a16c659ad6ec1b4d9559fcbcd40196086c60e
    Reviewed-on: https://go-review.googlesource.com/c/154380
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Dec 4, 2018
  1. go/doc: tune factory method association logic

    agnivade authored and griesemer committed Oct 10, 2018
    Ignore predeclared types (such as error) in result parameter lists when determining
    with which result type a method should be associated with. This change will again
    associate common factory functions with the first result type even if there are more
    than one result, as long as the others are predeclared types.
    
    Fixes #27928
    
    Change-Id: Ia2aeaed15fc4c8debdeeaf729cc7fbba1612cafb
    Reviewed-on: https://go-review.googlesource.com/c/141617
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Nov 29, 2018
  1. go/doc: convert to unicode quotes for ToText and Synopsis

    agnivade authored and griesemer committed Nov 20, 2018
    We refactor the conversion of quotes to their unicode equivalent
    to a separate function so that it can be called from ToText and Synopsis.
    
    And we introduce a temp buffer to write the escaped HTML and convert
    the unicode quotes back to html escaped entities. This simplifies the logic
    and gets rid of the need to track the index of the escaped text.
    
    Fixes #27759
    
    Change-Id: I71cf47ddcd4c6794ccdf2898ac25539388b393c1
    Reviewed-on: https://go-review.googlesource.com/c/150377
    Run-TryBot: Robert Griesemer <gri@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Nov 8, 2018
  1. time: add a missing comma in the documentation of Time

    agnivade authored and bradfitz committed Nov 8, 2018
    Updates #28421
    
    Change-Id: I3262c83669bc3cefd2cea6a612e3dc1d4318b2c2
    Reviewed-on: https://go-review.googlesource.com/c/148339
    Reviewed-by: Rob Pike <r@golang.org>
  2. time: handle negative offsets on js/wasm

    agnivade authored and bradfitz committed Nov 8, 2018
    Fixes #28649
    
    Change-Id: I9f6807ee3c3007f670dd509780805c7b255a2bda
    Reviewed-on: https://go-review.googlesource.com/c/148338
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  3. time: document that a marshaled time does not include location name

    agnivade authored and bradfitz committed Nov 7, 2018
    Fixes #28421
    
    Change-Id: I00878ec246d5249d910f2b57749f74cfc38dbec6
    Reviewed-on: https://go-review.googlesource.com/c/148117
    Reviewed-by: Rob Pike <r@golang.org>
Commits on Oct 31, 2018
  1. doc: replace command line usages of godoc with go doc

    agnivade authored and robpike committed Oct 29, 2018
    Effective Go and the FAQ still had some instances which showed the command line
    usage of godoc. Changed them to use go doc.
    
    Updates #25443
    
    Change-Id: If550963322034e6848bc466f79e968e7220e4a88
    Reviewed-on: https://go-review.googlesource.com/c/145222
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Oct 24, 2018
  1. time: return correct zone info on js/wasm

    agnivade authored and bradfitz committed Oct 18, 2018
    Fixes #28265
    
    Change-Id: I0a13e9f9c216647e42127a59a80b0f19618169c1
    Reviewed-on: https://go-review.googlesource.com/c/143577
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Richard Musiol <neelance@gmail.com>
Commits on Sep 27, 2018
  1. go/build: clarify that there are no build tags for minor releases

    agnivade authored and mvdan committed Sep 19, 2018
    Fixes #26458
    
    Change-Id: If932718ca8a2b230ab52495c1a7a82d86ab1325b
    Reviewed-on: https://go-review.googlesource.com/136215
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
Commits on Sep 14, 2018
  1. time: improve error message for LoadLocation

    agnivade authored and ianlancetaylor committed Jun 30, 2018
    Currently, when a tz file was being checked inside a zoneInfo dir,
    a syscall.ENOENT error was being returned, which caused it to look
    in the zoneinfo.zip file and return an error for that case.
    
    We return a syscall.ENOENT error for the zip file case too, so that
    it falls through to the end of the loop and returns an uniform error
    for both cases.
    
    Fixes #20969
    
    Change-Id: If1de068022ac7693caabb5cffd1c929878460140
    Reviewed-on: https://go-review.googlesource.com/121877
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
Commits on Sep 4, 2018
  1. cmd/go/internal/modcmd: remove non-existent -dir flag

    agnivade authored and bradfitz committed Aug 28, 2018
    Fixes #27243
    
    Change-Id: If9230244938dabd03b9afaa6600310df8f97fe92
    Reviewed-on: https://go-review.googlesource.com/131775
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
  2. misc/wasm: handle error during instantiateStreaming

    agnivade authored and bradfitz committed Sep 3, 2018
    The same catch block is there in wasm_exec.js for node processes.
    Added it in browser invocations too, to prevent uncaught exceptions.
    
    Change-Id: Icab577ec585fa86df3c76db508b49401bcdb52ae
    Reviewed-on: https://go-review.googlesource.com/132916
    Reviewed-by: Richard Musiol <neelance@gmail.com>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Aug 30, 2018
  1. cmd/dist: wait for run jobs to finish in case of a compiler error

    agnivade authored and ianlancetaylor committed Aug 3, 2018
    Instead of calling run synchronously, we pass it through bgrun
    and immediately wait for it to finish. This pushes all jobs
    to execute through the bgwork channel and therefore causes
    them to exit cleanly in case of a compiler error.
    
    Fixes #25981
    
    Change-Id: I789a85d23fabf32d144ab85a3c9f53546cb7765a
    Reviewed-on: https://go-review.googlesource.com/127776
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@golang.org>
Older
You can’t perform that action at this time.