Permalink
Switch branches/tags
weekly.2012-03-27 weekly.2012-03-22 weekly.2012-03-13 weekly.2012-03-04 weekly.2012-02-22 weekly.2012-02-14 weekly.2012-02-07 weekly.2012-01-27 weekly.2012-01-20 weekly.2012-01-15 weekly.2011-12-22 weekly.2011-12-14 weekly.2011-12-06 weekly.2011-12-02 weekly.2011-12-01 weekly.2011-11-18 weekly.2011-11-09 weekly.2011-11-08 weekly.2011-11-02 weekly.2011-11-01 weekly.2011-10-26 weekly.2011-10-25 weekly.2011-10-18 weekly.2011-10-06 weekly.2011-09-21 weekly.2011-09-16 weekly.2011-09-07 weekly.2011-09-01 weekly.2011-08-17 weekly.2011-08-10 weekly.2011-07-29 weekly.2011-07-19 weekly.2011-07-07 weekly.2011-06-23 weekly.2011-06-16 weekly.2011-06-09 weekly.2011-06-02 weekly.2011-05-22 weekly.2011-04-27 weekly.2011-04-13 weekly.2011-04-04 weekly.2011-03-28 weekly.2011-03-15 weekly.2011-03-07.1 weekly.2011-03-07 weekly.2011-02-24 weekly.2011-02-15 weekly.2011-02-01.1 weekly.2011-02-01 weekly.2011-01-20 weekly.2011-01-19 weekly.2011-01-12 weekly.2011-01-06 weekly.2010-12-22 weekly.2010-12-15.1 weekly.2010-12-15 weekly.2010-12-08 weekly.2010-12-02 weekly.2010-11-23 weekly.2010-11-10 weekly.2010-11-02 weekly.2010-10-27 weekly.2010-10-20 weekly.2010-10-13.1 weekly.2010-10-13 weekly.2010-09-29 weekly.2010-09-22 weekly.2010-09-15 weekly.2010-09-06 weekly.2010-08-25 weekly.2010-08-11 weekly.2010-08-04 weekly.2010-07-29 weekly.2010-07-14 weekly.2010-07-01 weekly.2010-06-21 weekly.2010-06-09 weekly.2010-05-27 weekly.2010-05-04 weekly.2010-04-27 weekly.2010-04-13 weekly.2010-03-30 weekly.2010-03-22 weekly.2010-03-15 weekly.2010-03-04 weekly.2010-02-23 weekly.2010-02-17 weekly.2010-02-04 weekly.2010-01-27 weekly.2010-01-13 weekly.2010-01-05 weekly.2009-12-22 weekly.2009-12-09 weekly.2009-12-07 weekly.2009-11-17 weekly.2009-11-12 weekly.2009-11-10.1 weekly.2009-11-10 weekly.2009-11-06 weekly
Nothing to show
Commits on Sep 18, 2018
  1. runtime: ignore EAGAIN from exec in TestCgoExecSignalMask

    ianlancetaylor committed Sep 18, 2018
    Fixes #27731
    
    Change-Id: Ifb4d57923b1bba0210ec1f623d779d7b5f442812
    Reviewed-on: https://go-review.googlesource.com/135995
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Michael Munday <mike.munday@ibm.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Sep 15, 2018
  1. time: return ENOENT from androidLoadTzinfoFromTzdata if zone not found

    ianlancetaylor committed Sep 14, 2018
    This makes Android consistent with the change in CL 121877.
    
    Updates #20969
    
    Change-Id: I1f114556fd1d4654c8e4e6a59513bddd5dc3d1a0
    Reviewed-on: https://go-review.googlesource.com/135416
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Elias Naur <elias.naur@gmail.com>
Commits on Sep 14, 2018
  1. runtime: use CleanCmdEnv in TestRuntimePanic

    ianlancetaylor committed Sep 14, 2018
    This makes TestRuntimePanic keep most of the existing environment,
    just as the other runtime tests do.
    
    Change-Id: I7944abfeee292d41716dca14483134a50d75f081
    Reviewed-on: https://go-review.googlesource.com/135376
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. cmd/go: correct gccgo buildid file on ARM

    ianlancetaylor committed Sep 13, 2018
    The GNU assembler for ARM treats @ as a comment character, so section
    types must be written using % instead.
    
    Fixes https://gcc.gnu.org/PR87260.
    
    Change-Id: I5461e4bf5b20793db321f540c7f25a9e6e12b6f4
    Reviewed-on: https://go-review.googlesource.com/135297
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
Commits on Sep 13, 2018
  1. path/filepath: correct symlink eval for symlink at root

    ianlancetaylor committed Sep 13, 2018
    For a relative symlink in the root directory, such as /tmp ->
    private/tmp, we were dropping the leading slash.
    
    No test because we can't create a symlink in the root directory.
    The test TestGZIPFilesHaveZeroMTimes was failing on the Darwin builders.
    
    Updates #19922
    Updates #20506
    
    Change-Id: Ic83cb6d97ad0cb628fc551ac772a44fb3e20f038
    Reviewed-on: https://go-review.googlesource.com/135295
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Robert Griesemer <gri@golang.org>
  2. path/filepath: rewrite walkSymlinks

    ianlancetaylor committed Jun 29, 2018
    Rather than try to work around Clean and Join on intermediate steps,
    which can remove ".." components unexpectedly, just do everything in
    walkSymlinks. Use a single loop over path components.
    
    Fixes #23444
    
    Change-Id: I4f15e50d0df32349cc4fd55e3d224ec9ab064379
    Reviewed-on: https://go-review.googlesource.com/121676
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Commits on Sep 11, 2018
  1. cmd/link: don't pass all linker args when testing flag

    ianlancetaylor committed Sep 7, 2018
    Some linker flags can actually be input files, which can cause
    misleading errors when doing the trial link, which can cause the
    linker to incorrectly decide that the flag is not supported, which can
    cause the link to fail.
    
    Fixes #27510
    Updates #27110
    Updates #27293
    
    Change-Id: I70c1e913cee3c813e7b267bf779bcff26d4d194a
    Reviewed-on: https://go-review.googlesource.com/134057
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
    Reviewed-by: Damien Neil <dneil@google.com>
Commits on Sep 7, 2018
  1. cmd/go: add -Wl,--export-dynamic to linker flag whitelist

    ianlancetaylor committed Sep 7, 2018
    Fixes #27496
    
    Change-Id: I53538c7697729294a9e50ace26a6a7183131e837
    Reviewed-on: https://go-review.googlesource.com/134016
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Andrew Bonventre <andybons@golang.org>
Commits on Aug 28, 2018
  1. cmd/go: add GOMIPS value to build id for mipsle

    ianlancetaylor committed Aug 27, 2018
    Strip a trailing "le" from the GOARCH value when calculating the GOxxx
    environment variable that affects it.
    
    Fixes #27260
    
    Change-Id: I081f30d5dc19281901551823f4f56be028b5f71a
    Reviewed-on: https://go-review.googlesource.com/131379
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 25, 2018
  1. cmd/go: don't let script grep commands match $WORK

    ianlancetaylor committed Aug 25, 2018
    If $WORK happens to contain the string that a stdout/stderr/grep
    command is searching for, a negative grep command will fail incorrectly.
    
    Fixes #27170
    Fixes #27221
    
    Change-Id: I84454d3c42360fe3295c7235d388381525eb85b4
    Reviewed-on: https://go-review.googlesource.com/131398
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
Commits on Aug 24, 2018
  1. runtime: mark sigInitIgnored nosplit

    ianlancetaylor committed Aug 24, 2018
    The sigInitIgnored function can be called by initsig before a shared
    library is initialized, before the runtime is initialized.
    
    Fixes #27183
    
    Change-Id: I7073767938fc011879d47ea951d63a14d1cce878
    Reviewed-on: https://go-review.googlesource.com/131277
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Aug 22, 2018
  1. runtime: remove unused function casp

    ianlancetaylor committed Feb 12, 2018
    Change-Id: I7c9c83ba236e1050e04377a7591fef7174df698b
    Reviewed-on: https://go-review.googlesource.com/130415
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. runtime: make TestGcSys actually test something

    ianlancetaylor authored and bradfitz committed Jul 7, 2018
    The workthegc function was being inlined, and the slice did not
    escape, so there was no memory allocation. Use a sink variable to
    force memory allocation, at least for now.
    
    Fixes #23343
    
    Change-Id: I02f4618e343c8b6cb552cb4e9f272e112785f7cf
    Reviewed-on: https://go-review.googlesource.com/122576
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  3. regexp/syntax: don't do both linear and binary sesarch in MatchRunePos

    ianlancetaylor committed Aug 21, 2018
    MatchRunePos is a significant element of regexp performance, so some
    attention to optimization is appropriate. Before this CL, a
    non-matching rune would do both a linear search in the first four
    entries, and a binary search over all the entries. Change the code to
    optimize for the common case of two runes, to only do a linear search
    when there are up to four entries, and to only do a binary search when
    there are more than four entries.
    
    Updates #26623
    
    name                             old time/op    new time/op    delta
    Find-12                             260ns ± 1%     275ns ± 7%   +5.84%  (p=0.000 n=8+10)
    FindAllNoMatches-12                 144ns ± 9%     143ns ±12%     ~     (p=0.187 n=10+10)
    FindString-12                       256ns ± 4%     254ns ± 1%     ~     (p=0.357 n=9+8)
    FindSubmatch-12                     587ns ±12%     593ns ±11%     ~     (p=0.516 n=10+10)
    FindStringSubmatch-12               534ns ±12%     525ns ±14%     ~     (p=0.565 n=10+10)
    Literal-12                          104ns ±14%     106ns ±11%     ~     (p=0.145 n=10+10)
    NotLiteral-12                      1.51µs ± 8%    1.47µs ± 2%     ~     (p=0.508 n=10+9)
    MatchClass-12                      2.47µs ± 1%    2.26µs ± 6%   -8.55%  (p=0.000 n=8+10)
    MatchClass_InRange-12              2.18µs ± 5%    2.25µs ±11%   +2.85%  (p=0.009 n=9+10)
    ReplaceAll-12                      2.35µs ± 6%    2.08µs ±23%  -11.59%  (p=0.010 n=9+10)
    AnchoredLiteralShortNonMatch-12    93.2ns ± 9%    93.2ns ±11%     ~     (p=0.716 n=10+10)
    AnchoredLiteralLongNonMatch-12      118ns ±10%     117ns ± 9%     ~     (p=0.802 n=10+10)
    AnchoredShortMatch-12               142ns ± 1%     141ns ± 1%   -0.53%  (p=0.007 n=8+8)
    AnchoredLongMatch-12                303ns ± 9%     304ns ± 6%     ~     (p=0.724 n=10+10)
    OnePassShortA-12                    620ns ± 1%     618ns ± 9%     ~     (p=0.162 n=8+10)
    NotOnePassShortA-12                 599ns ± 8%     568ns ± 1%   -5.21%  (p=0.000 n=10+8)
    OnePassShortB-12                    525ns ± 7%     489ns ± 1%   -6.93%  (p=0.000 n=10+8)
    NotOnePassShortB-12                 449ns ± 9%     431ns ±11%   -4.05%  (p=0.033 n=10+10)
    OnePassLongPrefix-12                119ns ± 6%     114ns ± 0%   -3.88%  (p=0.006 n=10+9)
    OnePassLongNotPrefix-12             420ns ± 9%     410ns ± 7%     ~     (p=0.645 n=10+9)
    MatchParallelShared-12              376ns ± 0%     375ns ± 0%   -0.45%  (p=0.003 n=8+10)
    MatchParallelCopied-12             39.4ns ± 1%    39.1ns ± 0%   -0.55%  (p=0.004 n=10+9)
    QuoteMetaAll-12                     139ns ± 7%     142ns ± 7%     ~     (p=0.445 n=10+10)
    QuoteMetaNone-12                   56.7ns ± 0%    61.3ns ± 7%   +8.03%  (p=0.001 n=8+10)
    Match/Easy0/32-12                  83.4ns ± 7%    83.1ns ± 8%     ~     (p=0.541 n=10+10)
    Match/Easy0/1K-12                   417ns ± 8%     394ns ± 6%     ~     (p=0.059 n=10+9)
    Match/Easy0/32K-12                 7.05µs ± 8%    7.30µs ± 9%     ~     (p=0.190 n=10+10)
    Match/Easy0/1M-12                   291µs ±17%     284µs ±10%     ~     (p=0.481 n=10+10)
    Match/Easy0/32M-12                 9.89ms ± 4%   10.27ms ± 8%     ~     (p=0.315 n=10+10)
    Match/Easy0i/32-12                 1.13µs ± 1%    1.14µs ± 1%   +1.51%  (p=0.000 n=8+8)
    Match/Easy0i/1K-12                 35.7µs ±11%    36.8µs ±10%     ~     (p=0.143 n=10+10)
    Match/Easy0i/32K-12                1.70ms ± 7%    1.72ms ± 7%     ~     (p=0.776 n=9+6)
    
    name                             old alloc/op   new alloc/op   delta
    Find-12                             0.00B          0.00B          ~     (all equal)
    FindAllNoMatches-12                 0.00B          0.00B          ~     (all equal)
    FindString-12                       0.00B          0.00B          ~     (all equal)
    FindSubmatch-12                     48.0B ± 0%     48.0B ± 0%     ~     (all equal)
    FindStringSubmatch-12               32.0B ± 0%     32.0B ± 0%     ~     (all equal)
    
    name                             old allocs/op  new allocs/op  delta
    Find-12                              0.00           0.00          ~     (all equal)
    FindAllNoMatches-12                  0.00           0.00          ~     (all equal)
    FindString-12                        0.00           0.00          ~     (all equal)
    FindSubmatch-12                      1.00 ± 0%      1.00 ± 0%     ~     (all equal)
    FindStringSubmatch-12                1.00 ± 0%      1.00 ± 0%     ~     (all equal)
    
    name                             old speed      new speed      delta
    QuoteMetaAll-12                   101MB/s ± 8%    99MB/s ± 7%     ~     (p=0.529 n=10+10)
    QuoteMetaNone-12                  458MB/s ± 0%   425MB/s ± 8%   -7.22%  (p=0.003 n=8+10)
    Match/Easy0/32-12                 385MB/s ± 7%   386MB/s ± 7%     ~     (p=0.579 n=10+10)
    Match/Easy0/1K-12                2.46GB/s ± 8%  2.60GB/s ± 6%     ~     (p=0.065 n=10+9)
    Match/Easy0/32K-12               4.66GB/s ± 7%  4.50GB/s ±10%     ~     (p=0.190 n=10+10)
    Match/Easy0/1M-12                3.63GB/s ±15%  3.70GB/s ± 9%     ~     (p=0.481 n=10+10)
    Match/Easy0/32M-12               3.40GB/s ± 4%  3.28GB/s ± 8%     ~     (p=0.315 n=10+10)
    Match/Easy0i/32-12               28.4MB/s ± 1%  28.0MB/s ± 1%   -1.50%  (p=0.000 n=8+8)
    Match/Easy0i/1K-12               28.8MB/s ±10%  27.9MB/s ±11%     ~     (p=0.143 n=10+10)
    Match/Easy0i/32K-12              19.0MB/s ±14%  19.1MB/s ± 8%     ~     (p=1.000 n=10+6)
    
    Change-Id: I238a451b36ad84b0f5534ff0af5c077a0d52d73a
    Reviewed-on: https://go-review.googlesource.com/130417
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 21, 2018
  1. math: test for pos/neg zero return of Ceil/Floor/Trunc

    ianlancetaylor committed Feb 1, 2018
    Ceil and Trunc of -0.2 return -0, not +0, but we didn't test that.
    
    Updates #23647
    
    Change-Id: Idbd4699376abfb4ca93f16c73c114d610d86a9f2
    Reviewed-on: https://go-review.googlesource.com/91335
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
  2. misc/cgo/testcarchive: make the tests work when using gccgo

    ianlancetaylor committed Feb 24, 2017
    Change-Id: I62a7a8ebbbc1f1a266234b53680768da157b2df5
    Reviewed-on: https://go-review.googlesource.com/130416
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
  3. runtime: don't use linkname to refer to internal/cpu

    ianlancetaylor committed Aug 9, 2018
    The runtime package already imports the internal/cpu package, so there
    is no reason for it to use go:linkname comments to refer to
    internal/cpu functions and variables. Since internal/cpu is internal,
    we can just export those names. Removing the obscurity of go:linkname
    outweighs the minor additional complexity added to the internal/cpu API.
    
    Change-Id: Id89951b7f3fc67cd9bce67ac6d01d44a647a10ad
    Reviewed-on: https://go-review.googlesource.com/128755
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Martin Möhrmann <moehrmann@google.com>
  4. cmd/vet: implement old TODO from testdata/print.go

    ianlancetaylor committed Jul 19, 2018
    The code was fixed in CL 108559 but the testing TODO was not implemented.
    
    Updates #22936
    
    Change-Id: I20a703260a181bbcf5f87609d6fb8221a182be1a
    Reviewed-on: https://go-review.googlesource.com/125038
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
    Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
  5. cmd/compile: only support -race and -msan where they work

    ianlancetaylor committed Jun 30, 2018
    Consolidate decision about whether -race and -msan options are
    supported in cmd/internal/sys. Use consolidated functions in
    cmd/compile and cmd/go. Use a copy of them in cmd/dist; cmd/dist can't
    import cmd/internal/sys because Go 1.4 doesn't have it.
    
    Fixes #24315
    
    Change-Id: I9cecaed4895eb1a2a49379b4848db40de66d32a9
    Reviewed-on: https://go-review.googlesource.com/121816
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 20, 2018
  1. testing: exit with error if testing.Short is called before flag.Parse

    ianlancetaylor authored and bradfitz committed Jul 2, 2018
    Change-Id: I2fa547d1074ef0931196066678fadd7250a1148d
    Reviewed-on: https://go-review.googlesource.com/121936
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 9, 2018
  1. cmd/go: include experiments in compiler tool ID

    ianlancetaylor committed Aug 8, 2018
    No test because testing this would require building a new toolchain
    with a different experiment.
    
    Fixes #26883
    
    Change-Id: Iadd513d0920ef12463006dd2a61e94370dd13f68
    Reviewed-on: https://go-review.googlesource.com/128735
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Aug 3, 2018
  1. cmd/internal/objfile: only consider executable segments for load address

    ianlancetaylor committed Aug 3, 2018
    Reportedly on some new Fedora systems the linker is producing extra
    load segments, basically making the dynamic section non-executable.
    We were assuming that the first load segment could be used to
    determine the program's load offset, but that is no longer true.
    Use the first executable load segment instead.
    
    Fixes #26369
    
    Change-Id: I5ee31ddeef2e8caeed3112edc5149065a6448456
    Reviewed-on: https://go-review.googlesource.com/127895
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. os: document that Remove removes only empty directories

    ianlancetaylor authored and robpike committed Aug 3, 2018
    Fixes #26507
    
    Change-Id: I967e4f897ca891c70ca8bb0e66b984530c240815
    Reviewed-on: https://go-review.googlesource.com/127835
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Rob Pike <r@golang.org>
  3. cmd/go: don't crash in go fmt on invalid input when using modules

    ianlancetaylor committed Aug 3, 2018
    Fixes #26792
    
    Change-Id: I9a878180af28e3939b654fd88bed150010dffde0
    Reviewed-on: https://go-review.googlesource.com/127856
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
  4. cmd/go: revert "cmd/go: no longer eval symlinks in inDir"

    ianlancetaylor committed Aug 3, 2018
    It breaks on the Darwin builders, with
    
    --- FAIL: TestTestCacheInputs (21.65s)
        go_test.go:5371: file.txt: old=2018-08-02 15:12:21.136438 -0700 PDT m=+219.458659208, info.ModTime=2018-08-02 15:12:21 -0700 PDT
        go_test.go:5377: running testgo [test testcache]
        go_test.go:5377: standard output:
        go_test.go:5377: ok  	testcache	0.013s
    
        go_test.go:5378: running testgo [test testcache]
        go_test.go:5378: standard output:
        go_test.go:5378: ok  	testcache	(cached)
    
        go_test.go:5382: running testgo [test testcache]
        go_test.go:5382: standard output:
        go_test.go:5382: ok  	testcache	0.172s
    
        go_test.go:5384: running testgo [test testcache]
        go_test.go:5384: standard output:
        go_test.go:5384: ok  	testcache	(cached)
    
        go_test.go:5387: running testgo [test testcache -run=FileSize]
        go_test.go:5387: standard output:
        go_test.go:5387: ok  	testcache	0.012s
    
        go_test.go:5388: running testgo [test testcache -run=FileSize]
        go_test.go:5388: standard output:
        go_test.go:5388: ok  	testcache	(cached)
    
        go_test.go:5391: running testgo [test testcache -run=FileSize]
        go_test.go:5391: standard output:
        go_test.go:5391: ok  	testcache	0.008s
    
        go_test.go:5393: running testgo [test testcache -run=FileSize]
        go_test.go:5393: standard output:
        go_test.go:5393: ok  	testcache	(cached)
    
        go_test.go:5396: running testgo [test testcache -run=Chdir]
        go_test.go:5396: standard output:
        go_test.go:5396: ok  	testcache	0.417s
    
        go_test.go:5397: running testgo [test testcache -run=Chdir]
        go_test.go:5397: standard output:
        go_test.go:5397: ok  	testcache	(cached)
    
        go_test.go:5400: running testgo [test testcache -run=Chdir]
        go_test.go:5400: standard output:
        go_test.go:5400: ok  	testcache	(cached)
    
        go_test.go:5401: did not notice file size change
        go_test.go:5401: pattern \(cached\) found unexpectedly in standard output
    FAIL
    
    Original CL description:
    
        Evaluating the symlinks was slowing down test cache checks.
    
        Fixes #26562
        Fixes #26726
    
                ijt:~/gopath/src/issue26562$ cat foo_test.go
                package foo_test
    
                import (
                        "fmt"
                        "os"
                        "path/filepath"
                        "testing"
                )
    
                // package and imports snipped
                func TestCache(t *testing.T) {
                        tmp := os.TempDir()
                        for i := 0; i < 1000000; i++ {
                                os.Stat(filepath.Join(tmp, fmt.Sprintf("%d", i)))
                        }
                }
                ijt:~/gopath/src/issue26562$ time ~/github/go/bin/go test -count=1
                PASS
                ok      issue26562      9.444s
    
                real    0m10.021s
                user    0m2.344s
                sys     0m7.835s
                ijt:~/gopath/src/issue26562$ time ~/github/go/bin/go test .
                ok      issue26562      (cached)
    
                real    0m0.802s
                user    0m0.551s
                sys     0m0.306s
    
    Updates #26562
    Updates #26726
    
    Change-Id: I7914ee57dc75bcbd7f0ea01c70bed97d67c810ea
    Reviewed-on: https://go-review.googlesource.com/127715
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 2, 2018
  1. doc/go1.11: remove go/scanner note

    ianlancetaylor committed Aug 2, 2018
    The relevant change was reverted in CL 127658.
    
    Updates #26671
    
    Change-Id: I0c555c8e18f4c7e289de56d3ef840d79cf0adac2
    Reviewed-on: https://go-review.googlesource.com/127659
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. go/scanner: continue adding directory to file name

    ianlancetaylor committed Aug 2, 2018
    Before CL 97795, when go/scanner saw a //line comment, it would clean
    the path and, if the path was relative, prepend the directory from the
    file name. This was not the best API because it meant that the
    behavior changed based on whether the code was running on Windows or
    not, and it meant that information from the //line directive was lost.
    So in CL 97795, among other changes, go/scanner was changed to simply
    return the filename given in the //line comment.
    
    Unfortunately existing tools such as unparam and unconvert expected
    the old behavior. In order to avoid breaking those tools, revert that
    part of the change.
    
    Fixes #26671
    
    Change-Id: Ifa06542bd19cda9d682ac33766ab9080444ba050
    Reviewed-on: https://go-review.googlesource.com/127658
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Aug 1, 2018
  1. misc/cgo/testcshared: force descriptor 30 to be closed when execing test

    ianlancetaylor committed Aug 1, 2018
    Fixes #26730
    
    Change-Id: I3396598282c814e75c0c4ef16f692dbe83d2935e
    Reviewed-on: https://go-review.googlesource.com/127395
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. cmd/cgo: don't give inconsistent typedef error for cgo-defined types

    ianlancetaylor committed Aug 1, 2018
    The cgo tool predefines some C types such as C.uint. Don't give an
    error if the type that cgo defines does not match the type in a header file.
    
    Fixes #26743
    
    Change-Id: I9ed3b4c482b558d8ffa8bf61eb3209415b7a9e3c
    Reviewed-on: https://go-review.googlesource.com/127356
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Keith Randall <khr@golang.org>
  3. go/build: accept ! in cgo arguments

    ianlancetaylor committed Aug 1, 2018
    The ! can show up when using ${SRCDIR} with uppercase letters in module names.
    
    Fixes #26716
    
    Change-Id: Ia474ed8ec40a88076e8aac21103f6c7bb3848bdb
    Reviewed-on: https://go-review.googlesource.com/127297
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Jul 31, 2018
  1. doc: mention Faccessat flags support in go1.11

    ianlancetaylor authored and bradfitz committed Jul 27, 2018
    Change-Id: I4d01be5330db06877065aabe7a3faf69bce0dfb2
    Reviewed-on: https://go-review.googlesource.com/126515
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Commits on Jul 27, 2018
  1. syscall: support Faccessat flags argument

    ianlancetaylor committed Jul 27, 2018
    The Linux kernel faccessat system call does not take a flags parameter.
    The flag parameter to the C library faccessat function is implemented in C.
    The syscall.Faccessat function takes a flags parameter. In older releases
    we have passed the flags parameter to the kernel, which ignored it.
    In CL 120015 we started returning an error if any flags were set.
    That seems clearly better than ignoring them, but it turns out that some
    code was using the flags. The code was previously subtly broken.
    Now it is obviously broken. That is better, but we can do better still:
    we can implement the flags as the C library does. That is what this CL does.
    
    Change-Id: I259bd6f240c3951e939b81c3032dead3d9c567b4
    Reviewed-on: https://go-review.googlesource.com/126415
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  2. cmd/cgo: don't resolve typedefs in -godefs mode

    ianlancetaylor committed Jul 25, 2018
    In -godefs mode any typedefs that appear in struct fields and the like
    will presumably be defined in the input file. If we resolve to the
    base type, those cross-references will not work. So for -godefs mode,
    keep the Go 1.10 behavior and don't resolve the typedefs in a loop.
    
    Fixes #26644
    
    Change-Id: I48cf72d9eb5016353c43074e6aff6495af326f35
    Reviewed-on: https://go-review.googlesource.com/125995
    Reviewed-by: Keith Randall <khr@golang.org>
Commits on Jul 25, 2018
  1. cmd/go: for missing binary-only package, say where it should be

    ianlancetaylor committed Jul 25, 2018
    Before this CL the user effectively has to guess at the expected
    location of a binary-only package. While the location is normally
    obvious ($GOPATH/pkg/GOOS_GOARCH/PATH/PKG.a) it is much less so when
    building with options that implicitly add an -installsufix option.
    
    Fixes #26590
    
    Change-Id: I753ef54d6dcf733bb456dba65a4a92e4db57a1b0
    Reviewed-on: https://go-review.googlesource.com/125818
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
  2. runtime: ignore GNU/Linux sigaction errors for signals 32 and 33

    ianlancetaylor committed Jul 25, 2018
    This avoids problems when running under QEMU. It seems that at least
    some QEMU versions turn the sigaction implementation into a call to
    the C library sigaction function. The C library function will reject
    attempts to set the signal handler for signals 32 and 33. Ignore
    errors in that case.
    
    Change-Id: Id443a9a32f6fb0ceef5c59a398e7ede30bf71646
    Reviewed-on: https://go-review.googlesource.com/125955
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: Heschi Kreinick <heschi@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>