Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also
.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
golang/go
0xmohit/go
95rangerxlt/go
Acidburn0zzz/go
Amd64R/go-1
Anthonymcqueen21/go
AnuchitO/go
Ares2013/go
BPI-SINOVOIP/go
BPing/go
BlackEragon/go
BubbleEric/go
Buddhilive/go
CNXTEoEorg/go
Caplost/go
ChiefMage/go
Citizenxin/go
DanielMorsing/go
Davidzhu001/go-1
Demznak/go
FiloSottile/go
GerogeZero/go
GoesToEleven/go
GuSWRolland/go
HCLAC/go
HogLang/hog
Hossein1995/go
Janatbek/go
JeremyChenn/go
Joyionline/go
JsCrimson/go
LgJianzhao/go
LittleRiverLian/go
LouisJenkinsCS/Go_With_Concurrent_Map_Builtin
March4/go
MarcusChang/go
Ndekere/go
OlgorittRobot/go
PEPE-net/go
Patrickofdyq/go
PhillipSz/go
RiverLempel/go
Rojackse/go
SeungKyun/go
SouthernCharmz/go
SpiderOak/go
SpivEgin/go
Sreng-S/go
TangTHL/go
TelegramSupport/go
TheByteKnight/go
VFOXITChick/go
VukDukic/go
WEI-HE/go
XenoAmess/go-free
Young55555/go
ZoranWong/go
aatmaca/go
adamgj/go
aj07/go
akaros/go-akaros
alash3al/go
alcret/go
alexrao/go
algorithmically/go
alimnastaev/go
aminger/go
amirdaneshvar/go
anlhord/go
anydream/gg
ascheglov/go
bernerdschaefer/atman
blackkking/go
boolinking/go
bruceloo/go
cag/go
cchamplin/go
ceseo/go
chenange/go
chenduzi/go
chmodawk/go
christopher-henderson/GoSearch
cookerzhu/go
cxytujie/go
cyberroadie/go-sctp
cyysu/go
dangen-effy/go
deeokay/go
devfeel/go
dhirajsharma/go
dlg-yahoo/go
dojotech/go
dsw0214/go
dvandra/go
ercanucan/go
ericlakich/go
freeliver/go
freezehe/go
gavinzhs/go
gdey/go
getlantern/go
githubwbs/go-1
glaubitz/go
gopher-lang/gopher
gtd138/go
haylhf/go
henrylee2cn/go
hnes/go-tool-trace-greediest-goroutines
hsiven/go
ibrahimdraidia/go
iexpos/go
iftikharuddin/go
imagineagents/go
imkira/go
jessicah/go
jjjhrl/go
johnkushkorov/go
josuamarcelc/go
jpoirier/go
khamuul/go
kingslair/go
lattera/go
leizhendong/go
letsencrypt/go
lifeNrun/go
linux-on-ibm-z/go
linxueyi2230/go
lokifist/go
lokistone/go
lucasmrthomaz/go
luisulbaranleonTSCI/go
luoyangen/go
macressler/go
marzwu/go
mcanthony/go
mengqingshare/go
mesb/go
mike10001/go
mingodad/go
minux/goios
mittywalter/go
mmcloughlin/go
mrmuxl/go
msn217/go
nadiasvertex/go
nataliegryphon/go
neelance/go
niilante/go
noodmaketest/go
nuuyoo/go
opptinmer/go
palmin/go
peterfarouk01/go
philhofer/go
phuslu/go
polaris1119/go
powertechpreview/go
qinchao0525/go
qxj006/go
rare/go
rdterner/go
roth1002/go
rsc/go
sakishum/go
sebastianviera/go
shadowsocks/go
shae1988/go
shailesh17/go
shenjinxi/go
shijuvar/go
shyamalschandra/go
sky101010ws/go
slavau/go
smallerhand/go
soloos/go
status-im/go
stormltf/go
sujiahong/go
sujunbo/go
tgin/go
u35s/go
v2pro/koala-go
varver/go
wfw727/go
woollplus/go
worawit/go
wubob/go
xiezhenye/go
ximiabc/go
xizhixing/go
xuanxinhuiqing/go
xuhaitao/go
yell-li/go
ylck/go
yuriigithub/go
zcwfeng/go
zhangdianchao/go
zhouzhengde/go
zmoon111/go
zwyzzu/go
Nothing to show
Choose a base branch
dev.boringcrypto.go1.8
dev.boringcrypto.go1.9
dev.boringcrypto.go1.10
dev.boringcrypto.go1.11
dev.boringcrypto
dev.cc
dev.debug
dev.garbage
dev.gcfe
dev.inline
dev.power64
dev.ssa
dev.tls
dev.typealias
master
release-branch.go1
release-branch.go1.1
release-branch.go1.2
release-branch.go1.3
release-branch.go1.4
release-branch.go1.5
release-branch.go1.6
release-branch.go1.7
release-branch.go1.8
release-branch.go1.9
release-branch.go1.10
release-branch.go1.11
release-branch.r57
release-branch.r58
release-branch.r59
release-branch.r60
Nothing to show
Choose a Head Repository
golang/go
0xmohit/go
95rangerxlt/go
Acidburn0zzz/go
Amd64R/go-1
Anthonymcqueen21/go
AnuchitO/go
Ares2013/go
BPI-SINOVOIP/go
BPing/go
BlackEragon/go
BubbleEric/go
Buddhilive/go
CNXTEoEorg/go
Caplost/go
ChiefMage/go
Citizenxin/go
DanielMorsing/go
Davidzhu001/go-1
Demznak/go
FiloSottile/go
GerogeZero/go
GoesToEleven/go
GuSWRolland/go
HCLAC/go
HogLang/hog
Hossein1995/go
Janatbek/go
JeremyChenn/go
Joyionline/go
JsCrimson/go
LgJianzhao/go
LittleRiverLian/go
LouisJenkinsCS/Go_With_Concurrent_Map_Builtin
March4/go
MarcusChang/go
Ndekere/go
OlgorittRobot/go
PEPE-net/go
Patrickofdyq/go
PhillipSz/go
RiverLempel/go
Rojackse/go
SeungKyun/go
SouthernCharmz/go
SpiderOak/go
SpivEgin/go
Sreng-S/go
TangTHL/go
TelegramSupport/go
TheByteKnight/go
VFOXITChick/go
VukDukic/go
WEI-HE/go
XenoAmess/go-free
Young55555/go
ZoranWong/go
aatmaca/go
adamgj/go
aj07/go
akaros/go-akaros
alash3al/go
alcret/go
alexrao/go
algorithmically/go
alimnastaev/go
aminger/go
amirdaneshvar/go
anlhord/go
anydream/gg
ascheglov/go
bernerdschaefer/atman
blackkking/go
boolinking/go
bruceloo/go
cag/go
cchamplin/go
ceseo/go
chenange/go
chenduzi/go
chmodawk/go
christopher-henderson/GoSearch
cookerzhu/go
cxytujie/go
cyberroadie/go-sctp
cyysu/go
dangen-effy/go
deeokay/go
devfeel/go
dhirajsharma/go
dlg-yahoo/go
dojotech/go
dsw0214/go
dvandra/go
ercanucan/go
ericlakich/go
freeliver/go
freezehe/go
gavinzhs/go
gdey/go
getlantern/go
githubwbs/go-1
glaubitz/go
gopher-lang/gopher
gtd138/go
haylhf/go
henrylee2cn/go
hnes/go-tool-trace-greediest-goroutines
hsiven/go
ibrahimdraidia/go
iexpos/go
iftikharuddin/go
imagineagents/go
imkira/go
jessicah/go
jjjhrl/go
johnkushkorov/go
josuamarcelc/go
jpoirier/go
khamuul/go
kingslair/go
lattera/go
leizhendong/go
letsencrypt/go
lifeNrun/go
linux-on-ibm-z/go
linxueyi2230/go
lokifist/go
lokistone/go
lucasmrthomaz/go
luisulbaranleonTSCI/go
luoyangen/go
macressler/go
marzwu/go
mcanthony/go
mengqingshare/go
mesb/go
mike10001/go
mingodad/go
minux/goios
mittywalter/go
mmcloughlin/go
mrmuxl/go
msn217/go
nadiasvertex/go
nataliegryphon/go
neelance/go
niilante/go
noodmaketest/go
nuuyoo/go
opptinmer/go
palmin/go
peterfarouk01/go
philhofer/go
phuslu/go
polaris1119/go
powertechpreview/go
qinchao0525/go
qxj006/go
rare/go
rdterner/go
roth1002/go
rsc/go
sakishum/go
sebastianviera/go
shadowsocks/go
shae1988/go
shailesh17/go
shenjinxi/go
shijuvar/go
shyamalschandra/go
sky101010ws/go
slavau/go
smallerhand/go
soloos/go
status-im/go
stormltf/go
sujiahong/go
sujunbo/go
tgin/go
u35s/go
v2pro/koala-go
varver/go
wfw727/go
woollplus/go
worawit/go
wubob/go
xiezhenye/go
ximiabc/go
xizhixing/go
xuanxinhuiqing/go
xuhaitao/go
yell-li/go
ylck/go
yuriigithub/go
zcwfeng/go
zhangdianchao/go
zhouzhengde/go
zmoon111/go
zwyzzu/go
Nothing to show
Choose a head branch
dev.boringcrypto.go1.8
dev.boringcrypto.go1.9
dev.boringcrypto.go1.10
dev.boringcrypto.go1.11
dev.boringcrypto
dev.cc
dev.debug
dev.garbage
dev.gcfe
dev.inline
dev.power64
dev.ssa
dev.tls
dev.typealias
master
release-branch.go1
release-branch.go1.1
release-branch.go1.2
release-branch.go1.3
release-branch.go1.4
release-branch.go1.5
release-branch.go1.6
release-branch.go1.7
release-branch.go1.8
release-branch.go1.9
release-branch.go1.10
release-branch.go1.11
release-branch.r57
release-branch.r58
release-branch.r59
release-branch.r60
Nothing to show
28
contributors
Commits on Jun 02, 2016
vendor: update vendored route
Updates golang.org/x/net/route to rev fac978c for: - route: fix typos in test Change-Id: I35de1d3f8e887c6bb5fe50e7299f2fc12e4426de Reviewed-on: https://go-review.googlesource.com/23660 Reviewed-by: Ian Lance Taylor <iant@golang.org>
cmd/compile: do not generate tail calls when dynamic linking on ppc64le
When a wrapper method calls the real implementation, it's not possible to use a tail call when dynamic linking on ppc64le. The bad scenario is when a local call is made to the wrapper: the wrapper will call the implementation, which might be in a different module and so set the TOC to the appropriate value for that module. But if it returns directly to the wrapper's caller, nothing will reset it to the correct value for that function. Change-Id: Icebf24c9a2a0a9a7c2bce6bd6f1358657284fb10 Reviewed-on: https://go-review.googlesource.com/23468 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
doc/go1.7.html: fix spelling of cancelation
We say "cancelation," not "cancellation." Fixes #15928. Change-Id: I66d545404665948a27281133cb9050eebf1debbb Reviewed-on: https://go-review.googlesource.com/23673 Reviewed-by: Ian Lance Taylor <iant@golang.org>
doc: mention net/http/httptrace package in release notes
Updates #15810 Change-Id: I689e18409a88c9e8941aa2e98f472c331efd455e Reviewed-on: https://go-review.googlesource.com/23674 Reviewed-by: Ian Lance Taylor <iant@golang.org>
net/http: http.Request.Context doc fix
The comment on http.Request.Context says that the context is canceled when the client's connection closes even though this has not been implemented. See #15927 Change-Id: I50b68638303dafd70f77f8f778e6caff102d3350 Reviewed-on: https://go-review.googlesource.com/23672 Reviewed-by: Andrew Gerrand <adg@golang.org>
runtime: fix typo in comment
Change-Id: I82e35770b45ccd1433dfae0af423073c312c0859 Reviewed-on: https://go-review.googlesource.com/23680 Reviewed-by: Andrew Gerrand <adg@golang.org>
misc/cgo/test,cmd/dist: enable (more) Cgo tests on iOS
For #15919 Change-Id: I9fc38d9c8a9cc9406b551315e1599750fe212d0d Reviewed-on: https://go-review.googlesource.com/23635 Reviewed-by: David Crawshaw <crawshaw@golang.org> Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
misc/cgo/test: fix issue9400 test on android/386
The test for #9400 relies on an assembler function that manipulates the stack pointer. Meanwile, it uses a global variable for synchronization. However, position independent code on 386 use a function call to fetch the base address for global variables. That function call in turn overwrites the Go stack. Fix that by fetching the global variable address once before the stack register manipulation. Fixes the android/386 builder. Change-Id: Ib77bd80affaa12f09d582d09d8b84a73bd021b60 Reviewed-on: https://go-review.googlesource.com/23683 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
cmd/dist: skip an unsupported test on darwin/arm
Fixes the darwin/arm builder (I hope) Change-Id: I8a3502a1cdd468d4bf9a1c895754ada420b305ce Reviewed-on: https://go-review.googlesource.com/23684 Run-TryBot: Elias Naur <elias.naur@gmail.com> Reviewed-by: David Crawshaw <crawshaw@golang.org>
reflect: document StructOf embedded fields limitation
This CL documents that StructOf currently does not generate wrapper methods for embedded fields. Updates #15924 Change-Id: I932011b1491d68767709559f515f699c04ce70d4 Reviewed-on: https://go-review.googlesource.com/23681 Reviewed-by: David Crawshaw <crawshaw@golang.org>
ALTree
and ianlancetaylor
doc/go1.7: fix typo in nsswitch.conf name
Fixes #15939 Change-Id: I120cbeac73a052fb3f328774e6d5e1534f11bf6b Reviewed-on: https://go-review.googlesource.com/23682 Reviewed-by: Ian Lance Taylor <iant@golang.org>
doc/go1.7.html: typo fix; replace "," at end of sentence with "."
Signed-off-by: Steven Phillips <steve@tryingtobeawesome.com> Change-Id: Ie7c3253a5e1cd43be8fa12bad340204cc6c5ca76 Reviewed-on: https://go-review.googlesource.com/23677 Reviewed-by: Ian Lance Taylor <iant@golang.org>
LK4D4
and ianlancetaylor
syscall: call setgroups for no groups on GNU/Linux
Skip setgroups only for one particular case: GidMappings != nil and GidMappingsEnableSetgroup == false and list of supplementary groups is empty. This patch returns pre-1.5 behavior for simple exec and still allows to use GidMappings with non-empty Credential. Change-Id: Ia91c77e76ec5efab7a7f78134ffb529910108fc1 Reviewed-on: https://go-review.googlesource.com/23524 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
runtime/cgo: avoid races on cgo_context_function
Change-Id: Ie9e6fda675e560234e90b9022526fd689d770818 Reviewed-on: https://go-review.googlesource.com/23610 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
runtime: only permit SetCgoTraceback to be called once
Accept a duplicate call, but nothing else. Change-Id: Iec24bf5ddc3b0f0c559ad2158339aca698601743 Reviewed-on: https://go-review.googlesource.com/23692 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
strconv: use Run for some benchmarks
This serves as an example of table-driven benchmarks which are analoguous to the common pattern for table-driven tests. Change-Id: I47f94c121a7117dd1e4ba03b3f2f8bcb5da38063 Reviewed-on: https://go-review.googlesource.com/23470 Run-TryBot: Marcel van Lohuizen <mpvl@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
syscall: deflake TestUnshare
Change-Id: I21a08c2ff5ebb74e158723cca323574432870ba8 Reviewed-on: https://go-review.googlesource.com/23662 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 03, 2016
encoding/json: fix docs on valid key names
This has been inaccurate since https://golang.org/cl/6048047. Fixes #15317. Change-Id: If93d2161f51ccb91912cb94a35318cf33f4d526a Reviewed-on: https://go-review.googlesource.com/23691 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
doc/go1.7.html: net/mail.ParseAddress is stricter
Fixes #15940. Change-Id: Ie6da6fef235c6a251caa96d45f606c05d118a0ac Reviewed-on: https://go-review.googlesource.com/23710 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Travis Beatty <travisby@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
cmd/go: fix staleness test for releases, also deflake it
Fixes #15933 Change-Id: I2cd6365e6d0ca1cafdc812fbfaaa55aa64b2b289 Reviewed-on: https://go-review.googlesource.com/23731 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/internal/obj, runtime: fixes for defer in 386 shared libraries
Any defer in a shared object crashed when GOARCH=386. This turns out to be two
bugs:
1) Calls to morestack were not processed to be PIC safe (must have been
possible to trigger this another way too)
2) jmpdefer needs to rewind the return address of the deferred function past
the instructions that load the GOT pointer into BX, not just past the call
Bug 2) requires re-introducing the a way for .s files to know when they are
being compiled for dynamic linking but I've tried to do that in as minimal
a way as possible.
Fixes #15916
Change-Id: Ia0d09b69ec272a176934176b8eaef5f3bfcacf04
Reviewed-on: https://go-review.googlesource.com/23623
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
bytes: use Run method for benchmarks
Change-Id: I34ab1003099570f0ba511340e697a648de31d08a Reviewed-on: https://go-review.googlesource.com/23427 Run-TryBot: Marcel van Lohuizen <mpvl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
net: don't leak test helper goroutine in TestAcceptTimeout
Fixes #15109. Change-Id: Ibfdedd6807322ebec84bacfeb492fb53fe066960 Reviewed-on: https://go-review.googlesource.com/23742 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
cmd/link: avoid name collision with DWARF .def suffix
Adding a .def suffix for DWARF info collided with the DWARF info, without the suffix, for a method named def. Change the suffix to ..def instead. Fixes #15926. Change-Id: If1bf1bcb5dff1d7f7b79f78e3f7a3bbfcd2201bb Reviewed-on: https://go-review.googlesource.com/23733 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
doc/go1.7.html: add missing <code> and </a>
Change-Id: I5f4bf89345dc139063dcf34da653e914386bcde6 Reviewed-on: https://go-review.googlesource.com/23735 Reviewed-by: Ian Lance Taylor <iant@golang.org>
runtime/cgo: add TSAN locks around mmap call
Change-Id: I806cc5523b7b5e3278d01074bc89900d78700e0c Reviewed-on: https://go-review.googlesource.com/23736 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
reflect: clear tflag for StructOf type
Fixes #15923 Change-Id: I3e56564365086ceb0bfc15db61db6fb446ab7448 Reviewed-on: https://go-review.googlesource.com/23760 Reviewed-by: Sebastien Binet <seb.binet@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/go: match go-import package prefixes by slash
The existing implementation for path collision resolution would
incorrectly determine that:
example.org/aa
collides with:
example.org/a
This change splits by slash rather than comparing on a byte-by-byte
basis.
Fixes: #15947
Change-Id: I18b3aaafbc787c81253203cf1328bb3c4420a0c4
Reviewed-on: https://go-review.googlesource.com/23732
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
doc/go1.7.html: html tidy
Change-Id: I0e07610bae641cd63769b520089f5d854d796648 Reviewed-on: https://go-review.googlesource.com/23770 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
cmd/cgo: check pointers for deferred C calls at the right time
We used to check time at the point of the defer statement. This change fixes cgo to check them when the deferred function is executed. Fixes #15921. Change-Id: I72a10e26373cad6ad092773e9ebec4add29b9561 Reviewed-on: https://go-review.googlesource.com/23650 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
cmd/go: re-enable TestCgoConsistentResults on solaris
Updates #13247. Change-Id: If5e4c9f4db05f58608b0eeed1a2312a04015b207 Reviewed-on: https://go-review.googlesource.com/23741 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Revert "cmd/go: re-enable TestCgoConsistentResults on solaris"
This reverts commit b89bcc1. Change-Id: Ief2f317ffc175f7e6002d0c39694876f46788c69 Reviewed-on: https://go-review.googlesource.com/23744 Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
Commits on Jun 05, 2016
runtime: fix typo
Fixes #15962 Change-Id: I1949e0787f6c2b1e19b9f9d3af2f712606a6d4cf Reviewed-on: https://go-review.googlesource.com/23786 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 06, 2016
net/http: send one Transfer-Encoding header when "chunked" set manually
Fixes #15960 Change-Id: I7503f6ede33e6a1a93cee811d40f7b297edf47bc Reviewed-on: https://go-review.googlesource.com/23811 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
time: warn about correct use of a Timer's Stop/Reset methods
Updates #14038 Fixes #14383 Change-Id: Icf6acb7c5d13ff1d3145084544c030a778482a38 Reviewed-on: https://go-review.googlesource.com/23575 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
net/http: send StatusOK on empty body with TimeoutHandler
Fixes #15948 Change-Id: Idd79859b3e98d61cd4e3ef9caa5d3b2524fd026a Reviewed-on: https://go-review.googlesource.com/23810 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 07, 2016
cmd/dist: use "set" instead of "export" in diagnostic message
On Windows, "export" doesn't mean anything, but Windows users are the most likely to see this message. Fixes #15977 Change-Id: Ib09ca08a7580713cacb65d0cdc43730765c377a8 Reviewed-on: https://go-review.googlesource.com/23840 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/compile: use fake package for allocating autos
Make sure auto names don't conflict with function names. Before this CL, we confused name a.len (the len field of the slice a) with a.len (the function len declared on a). Fixes #15961 Change-Id: I14913de697b521fb35db9a1b10ba201f25d552bb Reviewed-on: https://go-review.googlesource.com/23789 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/compile: fix heap dump test on android
go_android_exec is looking for "exitcode=" to decide the result of running a test. The heap dump test nondeterministically prints "finalized" right at the end of the test. When the timing is just right, we print "finalizedexitcode=0" and confuse go_android_exec. This failure happens occasionally on the android builders. Change-Id: I4f73a4db05d8f40047ecd3ef3a881a4ae3741e26 Reviewed-on: https://go-review.googlesource.com/23861 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
Commits on Jun 08, 2016
cmd/compile: cgen_append can handle complex targets
Post-liveness fix, the slices on both sides can now be indirects of & variables. The cgen code handles those cases just fine. Fixes #15988 Change-Id: I378ad1d5121587e6107a9879c167291a70bbb9e4 Reviewed-on: https://go-review.googlesource.com/23863 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
net/http: update bundled http2
Updates x/net/http2 to git rev 313cf39 for CLs 23812 and 23880: http2: GotFirstResponseByte hook should only fire once http2: fix data race on pipe Fixes #16000 Change-Id: I9c3f1b2528bbd99968aa5a0529ae9c5295979d1d Reviewed-on: https://go-review.googlesource.com/23881 Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
misc/cgo/testsanitizers: don't run some TSAN tests on GCC < 7
Before GCC 7 defined __SANITIZE_THREAD__ when using TSAN, runtime/cgo/libcgo.h could not determine reliably whether TSAN was in use when using GCC. Fixes #15983. Change-Id: I5581c9f88e1cde1974c280008b2230fe5e971f44 Reviewed-on: https://go-review.googlesource.com/23833 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
misc/android: make the exec wrapper exit code parsing more robust
Before, the Android exec wrapper expected the trailing exit code output on its own line, like this: PASS exitcode=0 However, some tests can sometimes squeeze in some output after the test harness outputs "PASS" and the newline. The TestWriteHeapDumpFinalizers test is particularly prone to this, since its finalizers println to standard out. When it happens, the output looks like this: PASS finalizedexitcode=0 Two recent failures caused by this race: https://build.golang.org/log/185605e1b936142c22350eef22d20e982be53c29 https://build.golang.org/log/e61cf6a050551d10360bd90be3c5f58c3eb07605 Since the "exitcode=" string is always echoed after the test output, the fix is simple: instead of looking for the last newline in the output, look for the last exitcode string instead. Change-Id: Icd6e53855eeba60b982ad3108289d92549328b86 Reviewed-on: https://go-review.googlesource.com/23750 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
runtime/cgo: restore the g pointer correctly in crosscall_s390x
R13 needs to be set to g because C code may have clobbered R13. Fixes #16006. Change-Id: I66311fe28440e85e589a1695fa1c42416583b4c6 Reviewed-on: https://go-review.googlesource.com/23910 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/compile: nilcheck interface value in go/defer interface call for SSA
This matches the behavior of the legacy backend. Fixes #15975 (if this is the intended behavior) Change-Id: Id277959069b8b8bf9958fa8f2cbc762c752a1a19 Reviewed-on: https://go-review.googlesource.com/23820 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 09, 2016
cmd/go: only run TestGoGetHTTPS404 where it works
The test TestGoGetHTTPS404 downloads a package that does not build on every OS, so change it to only run where the package builds. It's not great for the test to depend on an external package, but this is an improvement on the current situation. Fixes #15644. Change-Id: I1679cee5ab1e61a5b26f4ad39dc8a397fbc0da69 Reviewed-on: https://go-review.googlesource.com/23920 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
os: document that the runtime can write to standard error
Fixes #15970. Change-Id: I3f7d8316069a69d0e3859aaa96bc1414487fead0 Reviewed-on: https://go-review.googlesource.com/23921 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
crypto/subtle: expand abbreviation to eliminate confusion
Change-Id: I68d66fccf9cc8f7137c92b94820ce7d6f478a185 Reviewed-on: https://go-review.googlesource.com/23310 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
time: genzabbrs.go skips Feb when checking months
getAbbrs looks like it is checking each month looking for a change in the time zone abbreviation, but starts in Dec of the previous year and skips the month of February because of the overflow rules for AddDate. Changing the day to 1 starts at Jan 1 and tries all months in the current year. This isn't very important or likely to change output as zones usually span several months. Discovered when looking into time.AddDate behavior when adding months. Change-Id: I685254c8d21c402ba82cc4176e9a86b64ce8f7f7 Reviewed-on: https://go-review.googlesource.com/23322 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
time: document that RFC822/1123 don't parse all RFC formats
Fixes #14505. Change-Id: I46196b26c9339609e6e3ef9159de38c5b50c2a1b Reviewed-on: https://go-review.googlesource.com/23922 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
cmd/cgo: use function arg type for _cgoCheckPointerN function
When cgo writes a _cgoCheckPointerN function to handle unsafe.Pointer,
use the function's argument type rather than interface{}. This permits
type errors to be detected at build time rather than run time.
Fixes #13830.
Change-Id: Ic7090905e16b977e2379670e0f83640dc192b565
Reviewed-on: https://go-review.googlesource.com/23675
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
cmd/cgo: fix use of unsafe argument in new deferred function
The combination of https://golang.org/cl/23650 and https://golang.org/cl/23675 did not work--they were tested separately but not together. The problem was that 23650 introduced deferred argument checking, and the deferred function loses the type that 23675 started requiring. The fix is to go back to using an empty interface type in a deferred argument check. No new test required--fixes broken build. Change-Id: I5ea023c5aed71d70e57b11c4551242d3ef25986d Reviewed-on: https://go-review.googlesource.com/23961 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
cmd/compile: for tail calls in stubs, ensure args are alive
The generated code for interface stubs sometimes just messes with a few of the args and then tail-calls to the target routine. The args that aren't explicitly modified appear to not be used. But they are used, by the thing we're tail calling. Fixes #16016 Change-Id: Ib9b3a8311bb714a201daee002885fcb59e0463fa Reviewed-on: https://go-review.googlesource.com/23960 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
runtime: set $sp before $pc in gdb python script
When setting $pc, gdb does a backtrace using the current value of $sp, and it may complain if $sp does not match that $pc (although the assignment went through successfully). This happens with ARM SSA backend: when setting $pc it prints > Cannot access memory at address 0x0 As well as occasionally on MIPS64: > warning: GDB can't find the start of the function at 0xc82003fe07. > ... Setting $sp before setting $pc makes it happy. Change-Id: Idd96dbef3e9b698829da553c6d71d5b4c6d492db Reviewed-on: https://go-review.googlesource.com/23940 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com>
Commits on Jun 10, 2016
encoding/csv: update doc about comments whitespace
This patch updates the doc about comments whitespace for the encoding/csv package to reflect that leading whitespace before the hash will treat the line as not a comment. Fixes #13775. Change-Id: Ia468c75b242a487b4b2b4cd3d342bfb8e07720ba Reviewed-on: https://go-review.googlesource.com/23302 Reviewed-by: Ian Lance Taylor <iant@golang.org>
syscall: add a padding field to EpollEvent on s390x
Fixes #16021. Change-Id: I55df38bbccd2641abcb54704115002a9aa04325d Reviewed-on: https://go-review.googlesource.com/23962 Run-TryBot: Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
cmd/go: clarify go get documentation
Make the documentation for `go get` match the documentation for `go install`, since `go get` essentially invokes `go install`. Update #15825. Change-Id: I374d80efd301814b6d98b86b7a4a68dd09704c92 Reviewed-on: https://go-review.googlesource.com/23925 Reviewed-by: Andrew Gerrand <adg@golang.org>
go/parser: document that parse functions need valid token.FileSet
+ panic with explicit error if no file set it provided (Not providing a file set is invalid use of the API; panic is the appropriate action rather than returning an error.) Fixes #16018. Change-Id: I207f5b2a2e318d65826bdd9522fce46d614c24ee Reviewed-on: https://go-review.googlesource.com/24010 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
os: on GNU/Linux use waitid to avoid wait/kill race
On systems that support the POSIX.1-2008 waitid function, we can use it to block until a wait will succeed. This avoids a possible race condition: if a program calls p.Kill/p.Signal and p.Wait from two different goroutines, then it is possible for the wait to complete just before the signal is sent. In that case, it is possible that the system will start a new process using the same PID between the wait and the signal, causing the signal to be sent to the wrong process. The Process.isdone field attempts to avoid that race, but there is a small gap of time between when wait returns and isdone is set when the race can occur. This CL avoids that race by using waitid to wait until the process has exited without actually collecting the PID. Then it sets isdone, then waits for any active signals to complete, and only then collects the PID. No test because any plausible test would require starting enough processes to recycle all the process IDs. Update #13987. Update #16028. Change-Id: Id2939431991d3b355dfb22f08793585fc0568ce8 Reviewed-on: https://go-review.googlesource.com/23967 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 11, 2016
runtime: aeshash, xor seed in earlier
Instead of doing: x = input one round of aes on x x ^= seed two rounds of aes on x Do: x = input x ^= seed three rounds of aes on x This change provides some additional seed-dependent scrambling which should help prevent collisions. Change-Id: I02c774d09c2eb6917cf861513816a1024a9b65d7 Reviewed-on: https://go-review.googlesource.com/23577 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 12, 2016
cmd/go: remove invalid space in import comment docs
Generate package comment in alldocs.go using line comments rather than general comments. This scales better, general comments cannot contain the "*/" character sequence. Line comments do not have any restrictions on the comment text that can be contained. Remove the dependency on sed, which is not cross-platform, not go-gettable external command. Remove trailing whitespace from usage string in test.go. It's unnecessary. Fixes #16030. Change-Id: I3c0bc9955e7c7603c3d1fb4878218b0719d02e04 Reviewed-on: https://go-review.googlesource.com/23968 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/compile: fix OASWB rewriting in racewalk
Special case for rewriting OAS inits omitted OASWB, added that and OAS2FUNC. The special case cannot be default case, that causes racewalk to fail in horrible ways. Fixes #16008. Change-Id: Ie0d2f5735fe9d8255a109597b36d196d4f86703a Reviewed-on: https://go-review.googlesource.com/23954 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 13, 2016
cmd/link: put padding between functions, not at the end of a function
Functions should be declared to end after the last real instruction, not after the last padding byte. We achieve this by adding the padding while assembling the text section in the linker instead of adding the padding to the function symbol in the compiler. This change makes dtrace happy. TODO: check that this works with external linking Fixes #15969 Change-Id: I973e478d0cd34b61be1ddc55410552cbd645ad62 Reviewed-on: https://go-review.googlesource.com/24040 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
runtime: collect stack trace if SIGPROF arrives on non-Go thread
Fixes #15994. Change-Id: I5aca91ab53985ac7dcb07ce094ec15eb8ec341f8 Reviewed-on: https://go-review.googlesource.com/23891 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
os: use waitid to avoid wait/kill race on darwin
This change is a followup to https://go-review.googlesource.com/23967 for Darwin. Updates #13987. Updates #16028. Change-Id: Ib1fb9f957fafd0f91da6fceea56620e29ad82b00 Reviewed-on: https://go-review.googlesource.com/24020 Reviewed-by: Ian Lance Taylor <iant@golang.org>
os: use wait6 to avoid wait/kill race on freebsd
This change is a followup to https://go-review.googlesource.com/23967 for FreeBSD. Updates #13987. Updates #16028. Change-Id: I0f0737372fce6df89d090fe9847305749b79eb4c Reviewed-on: https://go-review.googlesource.com/24021 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Commits on Jun 14, 2016
os: fix build on freebsd/arm
Change-Id: I21fad94ff94e342ada18e0e41ca90296d030115f Reviewed-on: https://go-review.googlesource.com/24061 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
cmd/go: remove obsolete comment referring to deleted parameter
The dir parameter was removed in https://golang.org/cl/5732045. Fixes #15503. Change-Id: I02a6d8317233bea08633715a095ea2514822032b Reviewed-on: https://go-review.googlesource.com/24011 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <shurcool@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
cmd/go: include .syso files even if CGO_ENABLED=0
A .syso file may include information that should go into the object file that is not object code, and should be included even if not using cgo. The example in the issue is a Windows manifest file. Fixes #16050. Change-Id: I1f4f3f80bb007e84d153ca2d26e5919213ea4f8d Reviewed-on: https://go-review.googlesource.com/24032 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
crypto/x509: don't ignore asn1.Marshal error
I don't see how the call could fail, so, no test. Just a code cleanup in case it can fail in the future. Fixes #15987. Change-Id: If4af0d5e7d19cc8b13fb6a4f7661c37fb0015e83 Reviewed-on: https://go-review.googlesource.com/23860 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
cmd/compile, etc: handle many struct fields
This adds 8 bytes of binary size to every type that has methods. It is the smallest change I could come up with for 1.7. Fixes #16037 Change-Id: Ibe15c3165854a21768596967757864b880dbfeed Reviewed-on: https://go-review.googlesource.com/24070 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
os: fix blockUntilWaitable on freebsd/{386,arm}
The previous fix was wrong because it had two misunderstandings on
freebsd32 calling convention like the following:
- 32-bit id1 implies that it is the upper half of 64-bit id, indeed it
depends on machine endianness.
- 32-bit ARM calling convension doesn't conform to freebsd32_args,
indeed it does.
This change fixes the bugs and makes blockUntilWaitable work correctly
on freebsd/{386,arm}.
Fixes #16064.
Change-Id: I820c6d01d59a43ac4f2ab381f757c03b14bca75e
Reviewed-on: https://go-review.googlesource.com/24064
Reviewed-by: Ian Lance Taylor <iant@golang.org>
net: don't run TestLookupDotsWithLocalSource in short mode
Do run it on the builders, though. Fixes #15881. Change-Id: Ie42204d553cb18547ffd6441afc261717bbd9205 Reviewed-on: https://go-review.googlesource.com/24111 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Commits on Jun 15, 2016
context: document how to release resources associated with Contexts.
Some users don't realize that creating a Context with a CancelFunc attaches a subtree to the parent, and that that subtree is not released until the CancelFunc is called or the parent is canceled. Make this clear early in the package docs, so that people learning about this package have the right conceptual model. Change-Id: I7c77a546c19c3751dd1f3a5bc827ad106dd1afbf Reviewed-on: https://go-review.googlesource.com/24090 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
net/http: pass through server side Transfer-Encoding headers
Fixes #16063 Change-Id: I2e8695beb657b0aef067e83f086828d8857787ed Reviewed-on: https://go-review.googlesource.com/24130 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
syscall: skip TestUnshare if kernel does not support net namespace
Fixes #16056. Change-Id: Ic3343914742713851b8ae969b101521f25e85e7b Reviewed-on: https://go-review.googlesource.com/24132 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
runtime: if the test program hangs, try to get a stack trace
This is an attempt to get more information for #14809, which seems to occur rarely. Updates #14809. Change-Id: Idbeb136ceb57993644e03266622eb699d2685d02 Reviewed-on: https://go-review.googlesource.com/24110 Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by: Austin Clements <austin@google.com>
go/ast: fix comments misinterpreted as documentation
The comments describing blocks of Pos/End implementations for various nodes types are being misinterpreted as documentation for BadDecl, BadExpr, BadStmt, and ImportSpec's Pos methods. Change-Id: I935b0bc38dbc13e9305f3efeb437dd3a6575d9a1 Reviewed-on: https://go-review.googlesource.com/24152 Reviewed-by: Robert Griesemer <gri@golang.org>
Commits on Jun 16, 2016
runtime: remove useless loop from CgoCCodeSIGPROF test program
I verified that the test fails if I undo the change that it tests for. Updates #14732. Change-Id: Ib30352580236adefae946450ddd6cd65a62b7cdf Reviewed-on: https://go-review.googlesource.com/24151 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
internal/trace: err if binary is not supplied for old trace
Change-Id: Id25c90993c4cbb7449d7031301b6d214a67d7633 Reviewed-on: https://go-review.googlesource.com/24134 Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Run-TryBot: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/dist: make zosarch.go deterministic
Currently zosarch.go is written out in non-deterministic map order. Sort the keys and write it out in sorted order to make the generated file contents deterministic. Change-Id: Id490f0e8665a2c619c5a7a00a30f4fc64f333258 Reviewed-on: https://go-review.googlesource.com/24174 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
runtime: fix stale comment in lfstack
Change-Id: I6ef08f6078190dc9df0b2df4f26a76456602f5e8 Reviewed-on: https://go-review.googlesource.com/24176 Reviewed-by: Rick Hudson <rlh@golang.org>
Large diffs are not rendered by default.