Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: mis-handshake when a request has no origin header #10102

Closed
mikioh opened this issue Mar 7, 2015 · 1 comment
Closed

x/net/websocket: mis-handshake when a request has no origin header #10102

mikioh opened this issue Mar 7, 2015 · 1 comment
Milestone

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Mar 7, 2015

It returns a &url.Error{Op:"parse", URL:"", Err:"empty url"} error, but RFC 6455 says that "This header field is sent by browser clients; for non-browser clients, this header field may be sent if it makes sense in the context of those clients." in the Opening Handshake section.

@mikioh mikioh added the repo-net label Mar 7, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title websocket: mis-handshake when a request has no origin header x/net/websocket: mis-handshake when a request has no origin header Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-net label Apr 14, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented May 6, 2015

CL https://golang.org/cl/7034 mentions this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.