Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: Better Json decoding #10134

Closed
h4ck3rm1k3 opened this issue Mar 11, 2015 · 8 comments

Comments

Projects
None yet
6 participants
@h4ck3rm1k3
Copy link

commented Mar 11, 2015

I have made a patch for debugging two things:

  1. if a field could not get mapped into the object
  2. if the type could not get cast, what field name it is. this required more pumbing to route the key field name to the right spot.
    h4ck3rm1k3/google-go@3befeea

@mikioh mikioh changed the title Better Json decoding encoding/json: Better Json decoding Mar 11, 2015

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2015

Please take a look at http://golang.org/doc/contribute.html.

@h4ck3rm1k3

This comment has been minimized.

Copy link
Author

commented Mar 11, 2015

roger that. will do a review, but need time for that.

@minux

This comment has been minimized.

Copy link
Member

commented Mar 11, 2015

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2015

Nothing to do here, so closing the issue. If you want to make a specific feature request, I think that would be clearer if you open a new issue.

@davecheney

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2015

I am sorry but we cannot accept pull requests.

Please read http://golang.org/doc/contribute.html for instructions on how
to propose a change.
On 11 Mar 2015 23:50, "James Michael DuPont" notifications@github.com
wrote:

I have made a patch for debugging two things:

  1. if a field could not get mapped into the object
  2. if the type could not get cast, what field name it is. this required
    more pumbing to route the key field name to the right spot.
    h4ck3rm1k3/google-go@3befeea
    h4ck3rm1k3/google-go@3befeea


Reply to this email directly or view it on GitHub
#10134.

@h4ck3rm1k3

This comment has been minimized.

Copy link
Author

commented Mar 11, 2015

There is something to do. @ianlancetaylor the bug report is :

  1. field name not reported on type error, this is really time consuming to find out what field is failing.
  2. no error message of skipped fields.
    those are the things that I tried to fix. So I would like to leave this a bug report if you agree.
@h4ck3rm1k3

This comment has been minimized.

Copy link
Author

commented Mar 11, 2015

Please remember to discuss new features first, before sending the review.
I sent this item to the mailing list and this is the discussion. The
problem is that json decode is lacking any useful feedback in an error
condition.

On Wed, Mar 11, 2015 at 8:41 AM, Minux Ma notifications@github.com wrote:

Please remember to discuss new features first, before sending the review.

Reply to this email directly or view it on GitHub
#10134 (comment).

James Michael DuPont
Member of Free Libre Open Source Software Kosova http://www.flossk.org
Saving Wikipedia(tm) articles from deletion http://SpeedyDeletion.wikia.com

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2015

@h4ck3rm1k3 Please open a new issue describing the actual problem. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.