Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/eg: support ... package expansion #10142

Open
josharian opened this issue Mar 12, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@josharian
Copy link
Contributor

commented Mar 12, 2015

$ eg -w -t t.go cmd/...
cannot find package "cmd/..." in any of:

It'd be nice if eg supported ... the way that the go tool does.

I'm happy to do the legwork if desired.

@minux

This comment has been minimized.

Copy link
Member

commented Mar 12, 2015

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2015

Alternatively, we could expose an appropriate API in the main repo. This seems like the sort of thing that would be appropriate to expose in go/build.

(We could possibly also create a go/vcs package, but it's less clear to me that that is a good idea. Want to file a separate issue about go/vcs?)

@minux

This comment has been minimized.

Copy link
Member

commented Mar 12, 2015

By vcs package, I mean https://godoc.org/golang.org/x/tools/go/vcs.
cmd/go should vendor it and use it instead of maintain a copy in vcs.go.

Whether to add new API to go/build depends on how confident we are.
That's why I suggest adding API to x/tools/go/build first and see what
the community responds. We can always migrate it to go/build if we're
certain they are the correct design.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title cmd/eg: support ... package expansion x/tools/cmd/eg: support ... package expansion Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the repo-tools label Apr 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.