x/tools/cmd/eg: embedded fields are mishandled

[josharian]

$GOPATH/src/egbug/x.go:

package egbug

type T struct {
    *E
    E2 *E
}

type E struct {
    Next *T
}

func main() {
    var t *T
    t.Next = new(T)
}

Template:

package p

import "egbug"

func before(t *egbug.T) *egbug.T { return t.Next }
func after(t *egbug.T) *egbug.T  { return t.E2.Next }

eg output:

package egbug

type T struct {
    *E
    E2  *E
}

type E struct {
    Next *T
}

func main() {
    var t *T
    t.E2.E2.Next = new(T)
}

The second statement in main should be t.E2.Next, not t.E2.E2.Next. The output does not compile.

[josharian]

This is not just theoretical. I encountered it while working on a follow-up to CL 7360. Note that because the output doesn't typecheck, I can't just use eg to fix it as a workaround.

[josharian]

...and actually, it looks like this has to do with applying the transformation too many times, not with embedded fields. Sorry. Still a bug, though. :)

[Ripounet]

I noticed the same problem each time the "after" matches the "before" pattern, e.g. :

func before(str string) string { return strings.ToLower(str) }
func after(str string) string  { return strings.ToLower("[" + str + "]") }

-> brackets added twice instead of once.