Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build: leave farmer page for successful runs #10313
Comments
josharian
added
the
repo-build
label
Apr 1, 2015
josharian
assigned
bradfitz
Apr 1, 2015
This comment has been minimized.
This comment has been minimized.
|
The coordinator is stateless. It keeps some state in memory, but only a rolling window for the past N builds as a debug/curiosity mechanism. If it crashes or is restarted, it regains its state from Gerrit and build.golang.org. I'm not sure how such a feature would be implemented. The /try?commit=... URL is for people bored and interactively watching their try runs. The state gets stored back in Gerrit as a comment and -1/+1 vote as the TryBot-Success label. I suppose I could make unknown things just redirect back to the issue on Gerrit? Suggestions? |
This comment has been minimized.
This comment has been minimized.
This was me.
SGTM |
josharian commentedApr 1, 2015
CL 7360 started trybot run http://farmer.golang.org/try?commit=26677cd2. That farmer page was present for a while but now (30 minutes later) says "TryBot result not found (already done, invalid, or not yet discovered from Gerrit). Check Gerrit for results.". I presume that this is because the trybots were happy(?). I'd rather leave up a page that says that.