Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: leave farmer page for successful runs #10313

Closed
josharian opened this issue Apr 1, 2015 · 4 comments

Comments

@josharian
Copy link
Contributor

commented Apr 1, 2015

CL 7360 started trybot run http://farmer.golang.org/try?commit=26677cd2. That farmer page was present for a while but now (30 minutes later) says "TryBot result not found (already done, invalid, or not yet discovered from Gerrit). Check Gerrit for results.". I presume that this is because the trybots were happy(?). I'd rather leave up a page that says that.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 1, 2015

The coordinator is stateless. It keeps some state in memory, but only a rolling window for the past N builds as a debug/curiosity mechanism. If it crashes or is restarted, it regains its state from Gerrit and build.golang.org. I'm not sure how such a feature would be implemented.

The /try?commit=... URL is for people bored and interactively watching their try runs. The state gets stored back in Gerrit as a comment and -1/+1 vote as the TryBot-Success label.

I suppose I could make unknown things just redirect back to the issue on Gerrit?

Suggestions?

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2015

interactively watching their try runs.

This was me.

I suppose I could make unknown things just redirect back to the issue on Gerrit?

SGTM

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title build: leave farmer page for successful runs x/build: leave farmer page for successful runs Apr 14, 2015

@rsc rsc removed the repo-build label Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc added the Builders label Jun 11, 2015

@bradfitz bradfitz removed their assignment Sep 4, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Nowadays we have all the history uploaded to datastore so on that URL (http://farmer.golang.org/try?commit=26677cd2) we could look up 26677cd2 and at least say "That passed, here's the Gerrit link."

/cc @toothrot

@dmitshur

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

It looks like there's agreement to do even better and keep entire logs accessible in issue #34119. I'll close this 2015 issue in favor of that one. (@toothrot has already linked it there, so we can find it easily.)

@dmitshur dmitshur closed this Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.