New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: leave farmer page for successful runs #10313

Open
josharian opened this Issue Apr 1, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@josharian
Contributor

josharian commented Apr 1, 2015

CL 7360 started trybot run http://farmer.golang.org/try?commit=26677cd2. That farmer page was present for a while but now (30 minutes later) says "TryBot result not found (already done, invalid, or not yet discovered from Gerrit). Check Gerrit for results.". I presume that this is because the trybots were happy(?). I'd rather leave up a page that says that.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Apr 1, 2015

The coordinator is stateless. It keeps some state in memory, but only a rolling window for the past N builds as a debug/curiosity mechanism. If it crashes or is restarted, it regains its state from Gerrit and build.golang.org. I'm not sure how such a feature would be implemented.

The /try?commit=... URL is for people bored and interactively watching their try runs. The state gets stored back in Gerrit as a comment and -1/+1 vote as the TryBot-Success label.

I suppose I could make unknown things just redirect back to the issue on Gerrit?

Suggestions?

@josharian

This comment has been minimized.

Contributor

josharian commented Apr 2, 2015

interactively watching their try runs.

This was me.

I suppose I could make unknown things just redirect back to the issue on Gerrit?

SGTM

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title from build: leave farmer page for successful runs to x/build: leave farmer page for successful runs Apr 14, 2015

@rsc rsc removed the repo-build label Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc added the Builders label Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment