Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: default timeout value is too short for weaker CPUs to compute and pass all std tests. #10314

Closed
mortdeus opened this issue Apr 2, 2015 · 2 comments
Assignees
Milestone

Comments

@mortdeus
Copy link

@mortdeus mortdeus commented Apr 2, 2015

I have encountered an issue where ./all.bash returns a status indicating the build has failed to pass runtime/map_test.go because the test spends more than 2 mins executing code within testsCurrentReadsAfterGrowth() func on my Intel Atom n455e CPU. (1.67 GHz 64-bit single core cpu w/ 2 hyperthreads, no AES, 1GB DDR3, very lightweight Arch operating system with the latest kernel from the official Arch repo.).

I am currently testing to see if changing the default timeout from 2 mins to 5 mins will give my CPU enough time to finish the heavy computation.

@mortdeus
Copy link
Author

@mortdeus mortdeus commented Apr 2, 2015

Yeah, setting it higher worked. It took dist test 147 seconds to run the tests found in the runtime pkg on my system.

@mikioh mikioh changed the title default timeout value for dist test is too short for weaker CPUs to compute and pass all std tests. cmd/dist: default timeout value is too short for weaker CPUs to compute and pass all std tests. Apr 2, 2015
@mikioh mikioh added this to the Go1.5Maybe milestone Apr 2, 2015
@mikioh
Copy link
Contributor

@mikioh mikioh commented Apr 2, 2015

Please open a separate issue if you think TestConcurrentReadsAfterGrowth{,Reflect} in runtime/map_test.go need some fix.

@minux minux self-assigned this Apr 23, 2015
@minux minux closed this in 7579867 Apr 24, 2015
@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 17, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.