Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: comment movement during import add #10337

Closed
josharian opened this issue Apr 3, 2015 · 1 comment
Closed

x/tools/cmd/goimports: comment movement during import add #10337

josharian opened this issue Apr 3, 2015 · 1 comment
Assignees
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Apr 3, 2015

Migrated from #6982 comment 6:

http://play.golang.org/p/vXaSQ_EUUg

Before:

package main

import (
        "io" // I Am the Very Model of a Modern Major-General
)

var _ = io.Copy

func main() {
        log.Println("Hi")
}

After:

package main

import (
    "io"
    "log" // I Am the Very Model of a Modern Major-General
)

var _ = io.Copy

func main() {
    log.Println("Hi")
}

Note that the "io" import comment is now next to "log".

@josharian josharian added the repo-tools label Apr 3, 2015
@josharian josharian self-assigned this Apr 3, 2015
@josharian josharian changed the title cmd/goimports: comment movement during import add goimports: comment movement during import add Apr 3, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title goimports: comment movement during import add x/tools/cmd/goimports: comment movement during import add Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2016

CL https://golang.org/cl/19822 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.