Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/jpeg: silent failure of jpeg decoding #10357

Closed
mtaran-google opened this issue Apr 6, 2015 · 5 comments
Closed

image/jpeg: silent failure of jpeg decoding #10357

mtaran-google opened this issue Apr 6, 2015 · 5 comments
Milestone

Comments

@mtaran-google
Copy link

@mtaran-google mtaran-google commented Apr 6, 2015

  • What version of Go are you using (go version)? go1.4.2 darwin/amd64
  • What operating system and processor architecture are you using? Mac OS X 64-bit Intel
  • What did you do?
    • Open this jpeg with image/jpeg (it was produced by a scanner, and it renders fine in browsers, Preview, etc.)
  • What did you expect to see?
    • I expected Go to decode the image properly (i.e. white with black text).
  • What did you see instead?
    • It decoded the image as a black rectangle, with err == nil

Repro locally with this, though not on the playground.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 6, 2015

Please try with Go tip. @nigeltao piped ~all the JPEGs on the Internet through image/jpeg and fixed a number of bugs recently.

Loading

@mtaran-google
Copy link
Author

@mtaran-google mtaran-google commented Apr 6, 2015

It worked at head of master! Are these fixes scheduled for release in 1.4.3 or will it only make it into 1.5?

Loading

@minux
Copy link
Member

@minux minux commented Apr 6, 2015

Loading

@mtaran-google
Copy link
Author

@mtaran-google mtaran-google commented Apr 6, 2015

:'(

Loading

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 7, 2015

I'm not sure why that's sad. If this is affecting your work at Google, please mail the internal list for help and we can make sure tip image/jpeg is available to you immediately.

Loading

@mikioh mikioh changed the title silent failure of jpeg decoding image/jpeg: silent failure of jpeg decoding Apr 7, 2015
@mikioh mikioh added this to the Go1.5 milestone Apr 7, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants