Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: std lib tests don't consider +build tags #10370

Closed
griesemer opened this issue Apr 8, 2015 · 5 comments
Closed

go/types: std lib tests don't consider +build tags #10370

griesemer opened this issue Apr 8, 2015 · 5 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Apr 8, 2015

Some of the std lib tests (e.g. solaris-amd64) are failing because +build tags are ignored. The tests should consider the build tags in place for the test binary (because it depends on gcimporter which sees the files as built by gc for the current platform).

@griesemer griesemer self-assigned this Apr 8, 2015
@griesemer griesemer added this to the Go1.5Maybe milestone Apr 8, 2015
@rsc rsc changed the title go/types (std repo): std lib tests don't consider +build tags go/types: std lib tests don't consider +build tags Apr 26, 2015
@griesemer griesemer added this to the Go1.6 milestone Jun 23, 2015
@griesemer griesemer removed this from the Go1.5Maybe milestone Jun 23, 2015
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Sep 24, 2015

This is not super-important. Could be delayed to 1.7 or later w/o much repercussions.

Loading

@minux
Copy link
Member

@minux minux commented Sep 24, 2015

could we also consider exclude $GOROOT/src/*.go?
I usually place short repro files there when fixing bugs
because it's the most convenient place to place
test files. (see also https://golang.org/cl/14769 for a
similar issue wrt to go/build-ignored directories.)

Loading

@rsc rsc added this to the Unplanned milestone Dec 11, 2015
@rsc rsc removed this from the Go1.6 milestone Dec 11, 2015
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Nov 10, 2016

We already exclude files in $GOROOT/src. And go/importer (go/internal/gcimporter) is using go/build. I don't believe this is still a valid issue. Closing.

Loading

@griesemer griesemer closed this Nov 10, 2016
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Nov 1, 2017

I closed this prematurely. The issue is that go/types/stdlib_test.go's testTestDir function doesn't consider build tags I believe.

Loading

@griesemer griesemer reopened this Nov 1, 2017
@griesemer griesemer removed this from the Unplanned milestone Nov 1, 2017
@griesemer griesemer added this to the Go1.10 milestone Nov 1, 2017
@rsc rsc removed this from the Go1.10 milestone Nov 22, 2017
@rsc rsc added this to the Go1.11 milestone Nov 22, 2017
@griesemer griesemer removed this from the Go1.11 milestone Jun 27, 2018
@griesemer griesemer added this to the Go1.12 milestone Jun 27, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 24, 2018

Change https://golang.org/cl/144457 mentions this issue: go/types: automatically ignore $GOROOT/test files that contain build tags

Loading

@gopherbot gopherbot closed this in eecb5fd Oct 26, 2018
@golang golang locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants