cmd/pprof: SVG profile uses javascript from cyberz.org

[alicebob]

The .svg profile as generated by pprof's web command includes some Javascript from https://www.cyberz.org/projects/SVGPan/SVGPan.js

the file is linked here:

go/src/cmd/pprof/internal/driver/driver.go

Line 628 in 5f84238

flagSVGPan: flag.String("svgpan", "https://www.cyberz.org/projects/SVGPan/SVGPan.js", "URL for SVGPan Library"),

I found it surprising to find pprof's SVG has external dependencies. Not just because of tracking reasons (I don't think cyberz.org need to know about my pprof usage), but also because it doesn't always work (e.g. working on a train).

Would it be possible to just include the javascript code verbatim in the .SVG, or otherwise to not include the external link by default?

[dr2chase]

I note that the referenced code has a claimed-to-be-BSD license -- source/binary use and redistribution allowed with attribution and NO-WARRANTY.

[rsc]

The old Perl pprof (in Go 1.3) copied this code directly into the generated SVG.
The port to Go erred by trying to avoid this duplication and use a link.
The Go version of pprof will be updated to do what the Perl pprof did.

Thank you for the report.

[gopherbot]

CL https://golang.org/cl/10690 mentions this issue.

[alicebob]

Looks great. Thanks!