Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: flaky TestIdleConnChannelLeak #10427

Closed
bradfitz opened this issue Apr 12, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Apr 12, 2015

Flaky test seen on linux-amd64 at rev 947b6a7ec8e0

http://build.golang.org/log/ba81501397a2cf312dfcf83b4d32bfcbdc2fd03d

ok      mime/quotedprintable    0.195s
ok      net 2.532s
--- FAIL: TestIdleConnChannelLeak (0.00s)
    transport_test.go:1843: ForDisableKeepAlives = false, map size = 1; want 0
FAIL
FAIL    net/http    4.595s
ok      net/http/cgi    0.333s
ok      net/http/cookiejar  0.012s

@bradfitz bradfitz added this to the Go1.5Maybe milestone Apr 12, 2015

@crawshaw

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2015

This same error is happening frequently on the android-arm builder since I cleaned out its TMPDIR:

http://build.golang.org/log/b01531046245aead11b3269a2d601883b12f65c0

@bradfitz bradfitz self-assigned this Apr 15, 2015

@bradfitz bradfitz modified the milestones: Go1.5, Go1.5Maybe Apr 15, 2015

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2015

I've been unable to reproduce this. I've also read the code and can't see how it might occur.

There have been a number of fixes recently in the transport code, so hopefully one of those fixes also got this.

Please re-open if you see this again.

@bradfitz bradfitz closed this Apr 28, 2015

@crawshaw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

This appeared again this morning on linux-386, rev 3ca2021:

http://build.golang.org/log/9787432466e57bea66b3084a69f8a81a10603642

I still have no way to reliably reproduce it.

@bradfitz bradfitz reopened this Apr 30, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Apr 30, 2015

CL https://golang.org/cl/9561 mentions this issue.

@bradfitz bradfitz closed this in c723230 May 1, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.