Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: updating test data fails #10470

Closed
titanous opened this issue Apr 15, 2015 · 1 comment
Closed

crypto/tls: updating test data fails #10470

titanous opened this issue Apr 15, 2015 · 1 comment
Assignees
@agl
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@titanous
Copy link
Member

@titanous titanous commented Apr 15, 2015 

$ go test -update
...
Wrote testdata/Server-TLSv12-SNI
Wrote testdata/Server-TLSv12-SNI
Wrote testdata/Server-TLSv12-SNI
140735196164944:error:14094438:SSL routines:ssl3_read_bytes:tlsv1 alert internal error:s3_pkt.c:1461:SSL alert number 80
--- FAIL: TestHandshakeServerSNIGetCertificateError (0.01s)
    handshake_server_test.go:498: Error from Server.Write: Test error in GetCertificate
    handshake_server_test.go:572: Handshake failed
...
FAIL
exit status 1
FAIL    crypto/tls  1.978s

I've fixed this and will send a CL shortly.

/cc @agl
@titanous

This comment has been minimized.

Sign in to view
Copy link
Member Author

@titanous titanous commented Apr 15, 2015

https://go-review.googlesource.com/8959
@agl agl self-assigned this Apr 15, 2015
@agl agl closed this in c1e73dd Apr 16, 2015
@mikioh mikioh added this to the Go1.5 milestone Apr 17, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@titanous @agl
crypto/tls: fix test data generation
06b2973 
- Multiple GetCertificate tests shared the same name and were
  overwriting each other, each test now has a unique name.
- expectAlert was not implemented in the data updater, the single
  test that used it has been replaced with a ClientHello failure
  test.

Fixes golang#10470

Change-Id: I500738f6302ffa863d7ee45d85fa8773155e0614
Reviewed-on: https://go-review.googlesource.com/8959
Reviewed-by: Adam Langley <agl@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@titanous @agl
crypto/tls: fix test data generation
65d33c3 
- Multiple GetCertificate tests shared the same name and were
  overwriting each other, each test now has a unique name.
- expectAlert was not implemented in the data updater, the single
  test that used it has been replaced with a ClientHello failure
  test.

Fixes golang#10470

Change-Id: I500738f6302ffa863d7ee45d85fa8773155e0614
Reviewed-on: https://go-review.googlesource.com/8959
Reviewed-by: Adam Langley <agl@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agl agl

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@titanous @agl @mikioh @gopherbot
You can’t perform that action at this time.