Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: possible to lose CancelRequest between getConn and roundTrip #10511

Closed
bradfitz opened this issue Apr 20, 2015 · 1 comment

Comments

Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.5
4 participants
@bradfitz @DanielMorsing @mikioh @gopherbot
@bradfitz
Copy link
Member

commented Apr 20, 2015

As noted by @DanielMorsing, it's possible to lose a Transport.CancelRequest between dialing the conn and roundTrip.

There exists a small window where the cancel request is still:

        t.setReqCanceler(req, func() { close(cancelc) })

... but we've already dialed, but we haven't yet entered roundTrip and its:

    pc.t.setReqCanceler(req.Request, pc.cancelRequest)

@bradfitz bradfitz added this to the Go1.5Maybe milestone Apr 20, 2015

@DanielMorsing

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 20, 2015

https://go-review.googlesource.com/#/c/9181/

@DanielMorsing DanielMorsing closed this in 723f865 Apr 22, 2015

@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 15, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

@gopherbot gopherbot added the FrozenDueToAge label Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.