rpc module tries to register private methods

[msolo]

What steps will reproduce the problem?
1. create a private method on a service class, like this:

func (service *UmgmtService) closeListeners() (err os.Error) {
...
}

2. register your service, start your app and see:

2010/08/29 00:57:42 method closeListeners has wrong number of ins: 1

What is the expected output?

I would expect no message at all.


This patch should fix it:

diff -r 1fc1447ebedf src/pkg/rpc/server.go
--- a/src/pkg/rpc/server.go Sat Aug 28 07:54:16 2010 +1000
+++ b/src/pkg/rpc/server.go Sun Aug 29 00:54:21 2010 -0700
@@ -211,7 +211,7 @@
        method := s.typ.Method(m)
        mtype := method.Type
        mname := method.Name
-       if mtype.PkgPath() != "" && !isPublic(mname) {
+       if mtype.PkgPath() != "" || !isPublic(mname) {
            continue
        }
        // Method needs three ins: receiver, *args, *reply.

[robpike]

Comment 1:

This issue was closed by revision 64cb9b6.

Status changed to Fixed.