crypto/x509: reading certificates from PKCS12 files

[paulmey]

There is some interest to have a capability to read certificates from PKCS12 (.pfx/.p12) files in the golang standard library or the crypto sub repo. We have a package at https://github.com/Azure/go-pkcs12 that provides this capability and I'm looking for feedback on the API design. Moving Azure/go-pkcs12#9 here.

CC: @agl @rakyll @dgryski @nathany @ahmetalpbalkan

[nathany]

@agl @rakyll What's the next step? Would it make sense to contribute to x/crypto as is, and go through the code review process?

[agl]

I don't think this would be suitable for the standard library. It might be suitable for x/crypto.

It would really be best for the world if all the PKCS standards disappeared so there is a long-term cost to making it easier to use them. However, that doesn't remove the need that some people have to deal with them today.

It looks like an RC2 implementation would also have to be pulled in, which is fine, although it should probably be a subpackage of the PKCS#12 package—hopefully PKCS#12 is the last thing in the world that needs it.

The interface of the proposed package (https://godoc.org/github.com/Azure/go-pkcs12) looks plausible. As you can probably tell by the latency of my reply, I only get to work on this stuff on the odd weekend so it may take a while to get around to it, but the next step would be to create a code review to add the package to x/crypto.

[nathany]

Should the package also be able to write PKCS12 certs? Can that sort of thing be added later?

[agl]

It's certainly not necessary that the package be able to write PKCS#12 files in the initial revision. If it never needs to then so much the better.

[paulmey]

It looks like an RC2 implementation would also have to be pulled in, which is fine, although it should probably be a subpackage of the PKCS#12 package—hopefully PKCS#12 is the last thing in the world that needs it.

• @agl

@dgryski: would it be possible for you to contribute the RC2 code to the pkcs12 repo, so that I can contribute it to x/crypto? It would require a Microsoft CLA if you don't have one yet (much like contributing to Go requires a Google CLA).
Alternatively you can contribute your rc2 package to the x/crypto repo first and I'll follow with the pkcs12 package. I'd even prefer that, but I'm not sure how that works if rc2 is to be a subpackage of the pkcs12 package?

[dgryski]

Either route is fine with me. I just signed the Microsoft CLA. I can file a pull request against go-pkcs12 later today and then this issue can move forward.

[paulmey]

Thanks, that would be awesome. it will take me some time to get the Go CLA signed on behalf of MS...

[dgryski]

Just filed Azure/go-pkcs12#24 to merge go-rc2 into go-pkcs12.

[nathany]

@agl There is an open pull request to write PKCS12 files.
Azure/go-pkcs12#22

[paulmey]

@agl code review opened: https://go-review.googlesource.com/#/c/11986/
Contribution signed off by Microsoft legal, CLA signed

[mattn]

any update on this or CL?