testing: common.finished is accessed without holding common.mu lock #10640
Labels
Comments
The docs say: "FailNow must be called from the goroutine running the test or benchmark function, not from other goroutines created during the test." Also, you can't create your own *testing.T. So, I don't think there's anything to fix here. |
CL https://golang.org/cl/9545 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Note: CL to fix this is coming soon.
This triggers the race detector (for a good reason) when a test case fails by calling directly or indirectly t.FailNow() from two different goroutine.
Repro case
Actual
The text was updated successfully, but these errors were encountered: