Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: common.finished is accessed without holding common.mu lock #10640

Closed
maruel opened this issue Apr 30, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@maruel
Copy link
Contributor

commented Apr 30, 2015

Note: CL to fix this is coming soon.

This triggers the race detector (for a good reason) when a test case fails by calling directly or indirectly t.FailNow() from two different goroutine.

Repro case

func TestRace(t *testing.T) {
  t2 := testing.T{}
  var wg sync.WaitGroup
  for i := 0; i < 2; i++ {
    wg.Add(1)
    go func() {
      defer wg.Done()
      t2.FailNow()
    }()
  }
  wg.Wait()
}

Actual

go test ./testing -race
==================
WARNING: DATA RACE
Write by goroutine 30:
  testing.(*common).FailNow()
      /home/maruel/src/golang/src/testing/testing.go:333 +0x48
  testing_test.TestRace.func1()
      /home/maruel/src/golang/src/testing/testing_test.go:28 +0x5d

Previous write by goroutine 31:
  testing.(*common).FailNow()
      /home/maruel/src/golang/src/testing/testing.go:333 +0x48
  testing_test.TestRace.func1()
      /home/maruel/src/golang/src/testing/testing_test.go:28 +0x5d

Goroutine 30 (running) created at:
  testing_test.TestRace()
      /home/maruel/src/golang/src/testing/testing_test.go:29 +0x10f
  testing.tRunner()
      /home/maruel/src/golang/src/testing/testing.go:452 +0xfc

Goroutine 31 (finished) created at:
  testing_test.TestRace()
      /home/maruel/src/golang/src/testing/testing_test.go:29 +0x10f
  testing.tRunner()
      /home/maruel/src/golang/src/testing/testing.go:452 +0xfc
==================
PASS
Found 1 data race(s)
FAIL    testing 2.480s
@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 30, 2015

The docs say: "FailNow must be called from the goroutine running the test or benchmark function, not from other goroutines created during the test."

Also, you can't create your own *testing.T.

So, I don't think there's anything to fix here.

@bradfitz bradfitz closed this Apr 30, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Apr 30, 2015

CL https://golang.org/cl/9545 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.