Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: ignore lines starting with # #10659

Closed
DanielMorsing opened this issue May 1, 2015 · 3 comments
Closed

cmd/pprof: ignore lines starting with # #10659

DanielMorsing opened this issue May 1, 2015 · 3 comments
Milestone

Comments

@DanielMorsing
Copy link
Contributor

@DanielMorsing DanielMorsing commented May 1, 2015

Setting debug=1 on net/http/pprof queries gives a profile with # comments about stacks and memory usage. pprof should ignore these lines. Instead, it gives a parse failure.

@josharian
Copy link
Contributor

@josharian josharian commented May 1, 2015

And once pprof ignores those lines, reinstate CL 9491, perhaps with tests.

@gopherbot
Copy link

@gopherbot gopherbot commented May 2, 2015

CL https://golang.org/cl/9623 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented May 18, 2015

CL https://golang.org/cl/10212 mentions this issue.

josharian added a commit that referenced this issue May 18, 2015
This is a duplicate of CL 9491.
That CL broke the build due to pprof shortcomings
and was reverted in CL 9565.

CL 9623 fixed pprof, so this can go in again.

Fixes #10659.

Change-Id: If470fc90b3db2ade1d161b4417abd2f5c6c330b8
Reviewed-on: https://go-review.googlesource.com/10212
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@mikioh mikioh added this to the Go1.5 milestone May 23, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.