Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
syscall: Non-root Unix build fails after commit 055ecb7be580 in TestSCMCredentials #10703
If I build current git master at or after commit 055ecb7, it fails:
This is src/syscall/creds_test.go, which contains code that assumes a net.OpError.Err field is directly a syscall.EPERM:
This assumption is false after the commit. Now the syscall.EPERM is now wrapped up inside a SyscallError that's the result of calling os.NewSyscallError() in src/net/fd_unix.go's writeMsg().
The entire test here is conditional on os.Getuid() not being 0. I assume that the buildbots are running in some environment where os.Getuid() returns 0, which means this entire subtest in TestSCMCredentials() is being skipped. That may be a bug in itself (and there are a number of other tests that are conditional on the UID not being seen as 0).