Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run a non-root Linux builder #10719

Open
bradfitz opened this issue May 6, 2015 · 3 comments
Open

x/build: run a non-root Linux builder #10719

bradfitz opened this issue May 6, 2015 · 3 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 6, 2015

We should run at least non-root Linux builder to catch tests which accidentally require root.

(but we shouldn't run all builders as non-root, else we'll miss things assuming non-root)

Perhaps we make some existing weird builder also have this role, like linux-386-387, to not add resources or columns. We could rename it to 386-387noroot if we wanted?

/cc @minux @adg @crawshaw

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented May 6, 2015

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 12, 2019

We should run at least [one] non-root Linux builder to catch tests which accidentally require root.

We should specifically run at least one non-root Linux TryBot, and at least one non-root longtest builder (but probably also at least one root longtest builder, since long tests may also be sensitive to whether the user is root).

CC @dmitshur @toothrot @cagedmantis

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 12, 2019

Specifically, having ~all of the linux builders running as root causes us to skip (or fail to get adequate coverage for) any test that depends on making files or directories unwritable (as in #30316).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.