Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: data race in TestClientTimeout_Headers when -race=true -short=false #10780

Closed
mikioh opened this issue May 11, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mikioh
Copy link
Contributor

commented May 11, 2015

git rev-parse HEAD
19e81a9

==================
WARNING: DATA RACE
Write by goroutine 16:
  sync.raceWrite()
      /go/src/sync/race.go:41 +0x35
  sync.(*WaitGroup).Wait()
      /go/src/sync/waitgroup.go:125 +0x177
  net/http/httptest.(*Server).Close()
      /go/src/net/http/httptest/server.go:168 +0x83
  net/http_test.TestClientTimeout_Headers()
      /go/src/net/http/client_test.go:952 +0xb1a
  testing.tRunner()
      /go/src/testing/testing.go:454 +0xfb

Previous read by goroutine 22:
  sync.raceRead()
      /go/src/sync/race.go:37 +0x35
  sync.(*WaitGroup).Add()
      /go/src/sync/waitgroup.go:63 +0xc8
  net/http/httptest.(*waitGroupHandler).ServeHTTP()
      /go/src/net/http/httptest/server.go:198 +0x5f
  net/http.serverHandler.ServeHTTP()
      /go/src/net/http/server.go:1758 +0x209
  net/http.(*conn).serve()
      /go/src/net/http/server.go:1259 +0x1161

Goroutine 16 (running) created at:
  testing.RunTests()
      /go/src/testing/testing.go:562 +0xc95
  testing.(*M).Run()
      /go/src/testing/testing.go:492 +0xe7
  net/http_test.TestMain()
      /go/src/net/http/main_test.go:19 +0x35
  main.main()
      net/http/_test/_testmain.go:536 +0x20c

Goroutine 22 (running) created at:
  net/http.(*Server).Serve()
      /go/src/net/http/server.go:1806 +0x422
==================
PASS
Found 1 data race(s)
FAIL  net/http  43.465s

@mikioh mikioh added the Testing label May 11, 2015

@gopherbot

This comment has been minimized.

Copy link

commented May 11, 2015

CL https://golang.org/cl/9905 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.