Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestAcceptIgnoreSomeErrors is flaky on Windows #10785

bradfitz opened this issue May 11, 2015 · 3 comments

net: TestAcceptIgnoreSomeErrors is flaky on Windows #10785

bradfitz opened this issue May 11, 2015 · 3 comments


Copy link

@bradfitz bradfitz commented May 11, 2015

Flaky test noticed in trybot run :

--- FAIL: TestAcceptIgnoreSomeErrors (0.34s)
    net_windows_test.go:126: recv failed: read tcp> wsarecv: An existing connection was forcibly closed by the remote host.
FAIL    net 3.165s

/cc @mikioh @alexbrainman for any ideas

@bradfitz bradfitz added this to the Go1.5Maybe milestone May 11, 2015
Copy link

@mikioh mikioh commented May 12, 2015

Sent, but not addressed @alexbrainman' comments yet. Perhaps using internal/socktest might be enough because only thing we need to test here is simply observing that Accept never returns any errors when it receives broken connection requests from pending queue.

@mikioh mikioh self-assigned this May 12, 2015
@mikioh mikioh added the Testing label May 12, 2015
Copy link

@alexbrainman alexbrainman commented May 12, 2015

I can reproduce it on my windows-386 computer. So it was easy to fix


Copy link

@gopherbot gopherbot commented May 12, 2015

CL mentions this issue.

@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 23, 2015
@mikioh mikioh removed their assignment May 23, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.