Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/plan9, x/sys/windows: Environment functions should just refer to syscall functions #10803

Closed
ianlancetaylor opened this issue May 13, 2015 · 4 comments

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented May 13, 2015

In x/sys/unix/env_unix.go, the functions that deal with the environment just call the functions in the standard syscall package. The same should be done for x/sys/plan9/env_plan9.go and x/sys/windows/env_windows.go. I would just do it but I don't have the systems to test on, and as far as I know the trybots will only test the main repository, not x/sys.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 13, 2015

@0intro
Copy link
Member

@0intro 0intro commented May 13, 2015

I'll do it once I'll be back home next week.

@gopherbot
Copy link

@gopherbot gopherbot commented May 14, 2015

CL https://golang.org/cl/10077 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented May 14, 2015

CL https://golang.org/cl/10104 mentions this issue.

gopherbot pushed a commit to golang/sys that referenced this issue May 15, 2015
Make windows implementation similar to unix.

Updates golang/go#10803 (0intro will close the issue)

Change-Id: I6f6a7b1c84f54b1ec92f0346a9998df34235c71a
Reviewed-on: https://go-review.googlesource.com/10077
Reviewed-by: Rob Pike <r@golang.org>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.