Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/app: rename GetConfig #10899

Closed
rakyll opened this issue May 18, 2015 · 1 comment
Closed

x/mobile/app: rename GetConfig #10899

rakyll opened this issue May 18, 2015 · 1 comment
Assignees
Milestone

Comments

@rakyll
Copy link
Contributor

@rakyll rakyll commented May 18, 2015

Getters shouldn't include a Get prefix. Please find a better name.

cc/ @crawshaw @hyangah @minux

@crawshaw
Copy link
Contributor

@crawshaw crawshaw commented Jul 13, 2015

In general yes, but a Get prefix is sometimes used when the obvious symbol name is already taken by a type with the same name.

But regardless this is now obsolete, as the move to an event channel got rid of GetConfig.

@crawshaw crawshaw closed this Jul 13, 2015
@golang golang locked and limited conversation to collaborators Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.